Skip to content

[change] Handle skipped tests in SeleniumTestMixin #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nemesifier merged 1 commit into from
Jan 29, 2026
Merged

[change] Handle skipped tests in SeleniumTestMixin #570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions openwisp_utils/tests/selenium.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ def _setup_and_call(self, result, debug=False):
stream=None, descriptions=None, verbosity=0
)
super()._setup_and_call(result, debug)
# IMPORTANT: a skip is not a success; propagate it as a skip and stop.
if getattr(result, "skipped", None):
for _, reason in result.skipped:
original_result.addSkip(self, reason)
if hasattr(original_result, "events") and hasattr(result, "events"):
original_result.events = result.events
return
if result.wasSuccessful():
if attempt == 0:
original_result.addSuccess(self)
Expand Down
Loading