Skip to content

cligen: Initial packaging#22359

Merged
pprindeville merged 1 commit intoopenwrt:masterfrom
pprindeville:cligen-initial
Dec 5, 2023
Merged

cligen: Initial packaging#22359
pprindeville merged 1 commit intoopenwrt:masterfrom
pprindeville:cligen-initial

Conversation

@pprindeville
Copy link
Copy Markdown
Member

@pprindeville pprindeville commented Oct 10, 2023

Maintainer: me, @olofhagsand
Compile tested: x86_64, generic, HEAD (703d667)
Run tested: same, installed on test VM

Description:

CLIgen is a Command-Line Interface generator

cc: @olofhagsand

@pprindeville pprindeville force-pushed the cligen-initial branch 4 times, most recently from d08aee3 to 868c020 Compare October 10, 2023 18:17
@BKPepe BKPepe self-assigned this Oct 11, 2023
Comment thread utils/cligen/Makefile
Comment thread utils/cligen/Makefile Outdated
Comment thread utils/cligen/Makefile Outdated
Comment thread utils/cligen/Makefile Outdated
Comment thread utils/cligen/Makefile Outdated
Comment thread utils/cligen/Makefile Outdated
Comment thread utils/cligen/Makefile Outdated
Comment thread utils/cligen/Makefile Outdated
@pprindeville pprindeville force-pushed the cligen-initial branch 2 times, most recently from 6f6673b to 13459ce Compare October 23, 2023 16:19
@pprindeville
Copy link
Copy Markdown
Member Author

@BKPepe I think I got all of your comments addressed. Thanks for the thoughtful review!

@pprindeville pprindeville force-pushed the cligen-initial branch 2 times, most recently from f2a472a to 215920d Compare October 23, 2023 16:51
@pprindeville
Copy link
Copy Markdown
Member Author

@BKPepe Any idea why the ARM builds are failing on the install ... -s ... of the libraries?

@BKPepe
Copy link
Copy Markdown
Member

BKPepe commented Oct 23, 2023 via email

@pprindeville
Copy link
Copy Markdown
Member Author

If we can figure out this part:

/builder/staging_dir/host/bin/install -c -m 0755 -d /builder/build_dir/target-aarch64_generic_musl/cligen-6.4.0/ipkg-install/usr/lib
/builder/staging_dir/host/bin/install -c -m 0644 -s libcligen.so.6.4 /builder/build_dir/target-aarch64_generic_musl/cligen-6.4.0/ipkg-install/usr/lib
strip: Unable to recognise the format of the input file `/builder/build_dir/target-aarch64_generic_musl/cligen-6.4.0/ipkg-install/usr/lib/libcligen.so.6.4'
/builder/staging_dir/host/bin/install: strip process terminated abnormally
make[3]: *** [Makefile:157: install-lib] Error 1

we should be good to go. Not sure what the stripping and the ELF header have to do with each other... unless install only understands native architecture and we're not running the cross-compiled version.

@pprindeville
Copy link
Copy Markdown
Member Author

I will need to look into it.

Anything?

@LynxChaus
Copy link
Copy Markdown

/builder/staging_dir/host/bin/install is symlink to $(HOST)/usr/bin/install, default INSTALLFLAGS set in comfigure.ac to "-s" (strip).

You have two options:
1 - remove setting INSTALLFLAGS from configure.ac or Makefile.in
2 - tell install about rigth strip programm via '--strip-program=$STRIP'

@pprindeville pprindeville force-pushed the cligen-initial branch 3 times, most recently from 57ea857 to 523d050 Compare October 29, 2023 00:25
@LynxChaus
Copy link
Copy Markdown

Well. buildfarm configured with USE_SSTRIP, $(STRIP) set to "sstrip -z", install can't handle program with switches in --strip-program="..." switch.
So - remove -s from INSTALLFLAGS and call $(STRIP) $(PKG_INSTALL_DIR)/usr/lib/libcligen.so* naually in install section.
And remove debugging "file $(PKG_INSTALL_DIR)/usr/lib/libcligen.so*" entry from Makefile

Comment thread utils/cligen/Makefile Outdated
Comment thread utils/cligen/Makefile Outdated
Comment thread utils/cligen/Makefile Outdated
Comment thread utils/cligen/Makefile Outdated
@pprindeville
Copy link
Copy Markdown
Member Author

@BKPepe Please re-review.

@pprindeville
Copy link
Copy Markdown
Member Author

Well. buildfarm configured with USE_SSTRIP, $(STRIP) set to "sstrip -z", install can't handle program with switches in --strip-program="..." switch.
So - remove -s from INSTALLFLAGS and call (PKG_INSTALL_DIR)/usr/lib/libcligen.so* naually in install section.
And remove debugging "file $(PKG_INSTALL_DIR)/usr/lib/libcligen.so*" entry from Makefile

It's building now.

@pprindeville
Copy link
Copy Markdown
Member Author

@BKPepe @LynxChaus Are we good to merge?

CLIgen is a Command-Line Interface generator

Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
@pprindeville
Copy link
Copy Markdown
Member Author

@BKPepe @LynxChaus Are we good to merge?

Didn't hear back, so proceeding...

@pprindeville pprindeville merged commit a4b7f5a into openwrt:master Dec 5, 2023
@pprindeville pprindeville deleted the cligen-initial branch December 5, 2023 16:46
Comment thread utils/cligen/Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants