clixon: Initial packaging#22362
Merged
Merged
Conversation
pprindeville
force-pushed
the
clixon-initial
branch
from
e91e4af to
2b09950
Compare
Member
Author
|
Depends on PR #22359 |
BKPepe
requested changes
Oct 22, 2023
Member
BKPepe
left a comment
BKPepe
left a comment
There was a problem hiding this comment.
- Conffiles are missing, I bet there are some.
- Comments in the Makefile can be removed
- All these patches are included in upstream or pending there?
pprindeville
force-pushed
the
clixon-initial
branch
from
2b09950 to
e6c4ae6
Compare
Member
Author
|
Looks like the same cross-build issue with Also, while I was looking over the binaries resulting from a build, I realized that a couple of programs had pathnames hard-coded into them. I have a PR for this upstream but @olofhagsand needs to merge it first before I can (temporarily) copy it into the |
pprindeville
force-pushed
the
clixon-initial
branch
2 times, most recently
from
6e59792 to
91131f4
Compare
pprindeville
force-pushed
the
clixon-initial
branch
2 times, most recently
from
24462ed to
75760c1
Compare
pprindeville
force-pushed
the
clixon-initial
branch
3 times, most recently
from
d114451 to
47b4e7d
Compare
Member
Author
All of these issues have been addressed. Can I proceed? |
BKPepe
reviewed
Dec 5, 2023
pprindeville
force-pushed
the
clixon-initial
branch
from
47b4e7d to
843d2a9
Compare
BKPepe
reviewed
Dec 5, 2023
pprindeville
force-pushed
the
clixon-initial
branch
from
843d2a9 to
ecd9f8c
Compare
BKPepe
reviewed
Dec 5, 2023
Member
|
It seems like recent changes were not pushed, check it out |
pprindeville
force-pushed
the
clixon-initial
branch
3 times, most recently
from
243cc4c to
76adf84
Compare
BKPepe
reviewed
Dec 5, 2023
Member
Author
Yeah, was doing a test build before pushing... |
BKPepe
reviewed
Dec 5, 2023
pprindeville
force-pushed
the
clixon-initial
branch
2 times, most recently
from
a5cb84b to
3d60933
Compare
BKPepe
reviewed
Dec 5, 2023
Clixon is a YANG-based configuration manager, with interactive CLI, NETCONF and RESTCONF interfaces, an embedded database and transaction mechanism. Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
pprindeville
force-pushed
the
clixon-initial
branch
from
3d60933 to
7c3bf47
Compare
Member
Author
|
@BKPepe Can I please get an approve if everything has been addressed? |
Member
Author
Okay, if there are follow up review questions I'll do a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer: me, @olofhagsand
Compile tested: x86_64, generic, HEAD (66f6c20)
Run tested: same, installed on test VM
Description:
Clixon is a YANG-based configuration manager, with interactive CLI, NETCONF and RESTCONF interfaces, an embedded database and transaction mechanism.
cc: @olofhagsand