Merged
Conversation
bump glog version from 0.3.5 to 0.4.0 Tested by building another package which depends on glog and verify that it builds successfully. Signed-off-by: Amol Bhave <ambhave@fb.com>
ammubhave
added a commit
to ammubhave/glog
that referenced
this pull request
Apr 3, 2019
When glog 0.4.0 is built using musl instead of glibc, the compilation for this test fails because musl doesn't provide execinfo.h, which sets HAVE_STACKTRACE to false. Tested by building glog with musl and verifying that the build succeeds with this patch. [See openwrt/packages#8583] Signed-off-by: Amol Bhave <ambhave@fb.com>
neheb
approved these changes
Apr 3, 2019
Contributor
|
I take it the other packages has been ran? |
Contributor
Author
|
I ran |
Contributor
|
Hmm OK. Merging in that case. |
scpcom
pushed a commit
to scpcom/glog
that referenced
this pull request
May 22, 2025
When glog 0.4.0 is built using musl instead of glibc, the compilation for this test fails because musl doesn't provide execinfo.h, which sets HAVE_STACKTRACE to false. Tested by building glog with musl and verifying that the build succeeds with this patch. [See openwrt/packages#8583] Signed-off-by: Amol Bhave <ambhave@fb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bump glog version from 0.3.5 to 0.4.0
The attached patch is needed because glog 0.4.0's symbolize_unittest.cc compilation is broken for musl.
Tested by building another package which depends on glog and verify that
it builds successfully.
Signed-off-by: Amol Bhave ambhave@fb.com