This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Fix symbolize_unittest for musl builds#443
Merged
sergiud merged 1 commit intogoogle:masterfrom Oct 31, 2019
Merged
Conversation
When glog 0.4.0 is built using musl instead of glibc, the compilation for this test fails because musl doesn't provide execinfo.h, which sets HAVE_STACKTRACE to false. Tested by building glog with musl and verifying that the build succeeds with this patch. [See openwrt/packages#8583] Signed-off-by: Amol Bhave <ambhave@fb.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When glog 0.4.0 is built using musl instead of glibc, the compilation
for this test fails because musl doesn't provide execinfo.h, which sets
HAVE_STACKTRACE to false.
Tested by building glog with musl and verifying that the build succeeds
with this patch. [See https://github.com/openwrt/packages/pull/8583]
Signed-off-by: Amol Bhave ambhave@fb.com