Conversation
|
your title is misleading, these are very separate things to be doing to the package, all tryign to sneak in under "use nanosleep" File these separately, or at least as separate commits. I sitll have same comments as I'm going to have on all of these, whhere's the upstream ticket for the usleep/nanosleep conversion? |
amir-sabbaghi
left a comment
amir-sabbaghi
left a comment
There was a problem hiding this comment.
I would also appreciate it if you make separate PRs for usleep and cmake.
Allows removal of InstallDev as well as further simplification. Also 100KB smaller package. Added some C/LDFLAGS to further reduce the size. Small Makefile cleanups. Signed-off-by: Rosen Penev <rosenp@gmail.com>
Optionally fixes compilation with uClibc-ng. Signed-off-by: Rosen Penev <rosenp@gmail.com>
|
Should be good now. |
|
Well you didn't create a separate PR. But it looks good to me anyway. |
|
Just wait on upstream, it just adds unnecessary overhead |
|
@amir-sabbaghi Well, the main benefit of separate PRs is running through both commits through CircleCI individually. Both do in this case as the second commit is only for uClibc-ng. As for upstream, it seems they're relatively inactive. The other patch for glog was sent two months ago. No comment. google/glog#443 |
4 participants
Optionally fixes compilation with uClibc-ng.
Also switched to CMake. Allows removal of InstallDev as well as further
simplification. Also 100KB smaller package.
Added some C/LDFLAGS to further reduce the size.
Signed-off-by: Rosen Penev rosenp@gmail.com
Maintainer: @amir-sabbaghi
Compile tested: arc700