Media type/mtype clean up#60
Closed
Serhii Nesprava (sergseven) wants to merge 3 commits intomasterfrom
Closed
Conversation
Serhii Nesprava (sergseven)
changed the title
| function buildRequests(bids, bidderRequest) { | ||
| let videoBids = bids.filter(bid => isVideoBid(bid)); | ||
| let bannerAndNativeBids = bids.filter(bid => isBannerBid(bid) || isNativeBid(bid)) | ||
| function buildRequests(bidRequests, bidderRequest) { |
There was a problem hiding this comment.
NOTE: there is a room for an improvement to remove this custom logic at all, since we support multi-imp multi-adplacement bidrequests(https://github.com/openx/exchange-diagrams/blob/master/misc/multi-glossary.md#multi-imp-multi-ad-placement-bidrequest).
Gabriela Międlar (gmiedlar-ox)
approved these changes
Mar 7, 2025
Rafał Sieczka (bukrain)
approved these changes
Mar 10, 2025
Author
|
prebid#12855 created |
Serhii Nesprava (sergseven)
changed the title
Author
|
prebid#12855 merged |
Marcin Wrobel (marcin-wrobel-ox)
pushed a commit
that referenced
this pull request
Feb 13, 2026
… time, support region, bugfixes (prebid#14374) * AGT-734: Support region for prebid modules (merge 0_3_4 with master) * AGT-730: move spd to partnerData (merge 0_3_4 to master) * AGT-765: Send ad size and pos in impression reporting module (#58) * AGT-765: pos and size * AGT-765: Tests for position resolving * AGT-765: Test fix * AGT-756: Missed vrref in payload fix (#56) * AGT-756: vrref in payload fix * remove comment * AGT-756: Fix vrref bug * AGT-756: Remove comments * AGT-756: Test for vrref * update requestRtt to show more clear time (#59) * AGT-739: Change time to call server (#57) * fix typo, remove parameter duplication (#60) * fix typo, remove parameter duplication * update doc examples * AGT-721: Documentation for region, size, pos (#61) * fix region parameter in table (#62) * update tests * remove unused test --------- Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EXCH-11782
We remove the media type guessing logic, so we are ultimately rely on the bid.mtype response value, which is now required.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Other information