Skip to content
This repository was archived by the owner on Mar 3, 2025. It is now read-only.

(actions): add unit test#31

Merged
anik120 merged 1 commit intooperator-framework:mainfrom
anik120:unit-action
Apr 14, 2023
Merged

(actions): add unit test#31
anik120 merged 1 commit intooperator-framework:mainfrom
anik120:unit-action

Conversation

@anik120
Copy link
Copy Markdown
Member

@anik120 anik120 commented Apr 11, 2023

No description provided.

@everettraven
Copy link
Copy Markdown
Collaborator

Based on #29 (review) && #29 (comment) are we okay with just adding the unit test workflow or should we supersede this PR with a new PR that implements the matrix style workflow?

@anik120
Copy link
Copy Markdown
Member Author

anik120 commented Apr 12, 2023

My opinion is that we should go ahead and add the unit test action right now. Once #34 is in we'll be in a position to write some test cases for the CatalogSource reconciler that should be useful even when we're making the switch for the child resources/moving to aggregated api etc etc. Also feels like the right time to get at least the initial set of tests written down. So we can add the action, and then discuss the "matrix style tests"

I'll also need more clarification about the meaning of "matrix style tests", unless that means "rename sanity.yaml to test.yaml and add the unit test job to that file", in which I'm happy to do that in this PR

Copy link
Copy Markdown
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2023
Comment thread .github/workflows/unit.yaml
@anik120 anik120 merged commit ef7524b into operator-framework:main Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants