WIP: Adding Knative Kafka 0.12.1 operator updates#1164
Conversation
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
|
/retest |
|
@matzew: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@matzew: GitHub didn't allow me to request PR reviews from the following users: aliok. Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@matzew, I think this error could point to something: correct status is Unavailable, there we have Unknown. Compare here |
| spec: | ||
| apiservicedefinitions: {} | ||
| customresourcedefinitions: | ||
| owned: |
There was a problem hiding this comment.
a displayName seems to be required here.
| verbs: | ||
| - '*' | ||
| serviceAccountName: knative-kafka-operator | ||
| deployments: |
There was a problem hiding this comment.
In previous version (0.11.2), the only deployment in the CSV was the knative-kafka-operator ... the operator then installed the kafka-ch-dispatcher , controller and webhook after creating the KnativeEventingKafka CR. Having these in CSV will mean these will be created in the namespace of the Subscription. Was this change deliberate?
There was a problem hiding this comment.
I think the deployments were added in the CSV by mistake.
There was a problem hiding this comment.
@aliok can you follow up on this? Since you did the actual Operator update, there might be some diff between your work, and my PR to the hub.
I can also close this now, and have you PR the ultimate solution
|
/close |
|
@matzew: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Updates to existing Operators
replacesproperty?package.yaml?Your submission should not
upstream-community-operatorsandcommunity-operatorsat onceOperator Description must contain (in order)
Operator Metadata should contain
Remember that you can preview your CSV here.
--
1 If you feel your Operator does not fit any of the pre-defined categories, file a PR against this repo and explain your need
2 For more information see here