Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

WIP: Adding Knative Kafka 0.12.1 operator updates#1164

Closed
matzew wants to merge 1 commit into
operator-framework:masterfrom
matzew:adding_kafka_0.12.1
Closed

WIP: Adding Knative Kafka 0.12.1 operator updates#1164
matzew wants to merge 1 commit into
operator-framework:masterfrom
matzew:adding_kafka_0.12.1

Conversation

@matzew
Copy link
Copy Markdown
Contributor

@matzew matzew commented Jan 29, 2020

Updates to existing Operators

  • Is your new CSV pointing to the previous version with the replaces property?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Submit operators to both upstream-community-operators and community-operators at once
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file a PR against this repo and explain your need

2 For more information see here

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2020
@openshift-ci-robot openshift-ci-robot added openshift-operator An Operator targeting OpenShift / OKD size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 29, 2020
@matzew
Copy link
Copy Markdown
Contributor Author

matzew commented Jan 31, 2020

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@matzew: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Copy Markdown
Contributor Author

matzew commented Feb 3, 2020

@J0zi @dmesser I am not really sure I understand the reported error

/cc @aliok

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@matzew: GitHub didn't allow me to request PR reviews from the following users: aliok.

Note that only operator-framework members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@J0zi @dmesser I am not really sure I understand the reported error

/cc @aliok

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@J0zi
Copy link
Copy Markdown
Collaborator

J0zi commented Feb 3, 2020

@matzew, I think this error could point to something:
sync "test-operator" failed: {knative-kafka-operator-test null {test-operators openshift-marketplace}} not found: rpc error: code = Unknown desc = no entry found for knative-kafka-operator-test null

correct status is Unavailable, there we have Unknown. Compare here

@J0zi J0zi self-assigned this Feb 3, 2020
spec:
apiservicedefinitions: {}
customresourcedefinitions:
owned:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a displayName seems to be required here.

verbs:
- '*'
serviceAccountName: knative-kafka-operator
deployments:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In previous version (0.11.2), the only deployment in the CSV was the knative-kafka-operator ... the operator then installed the kafka-ch-dispatcher , controller and webhook after creating the KnativeEventingKafka CR. Having these in CSV will mean these will be created in the namespace of the Subscription. Was this change deliberate?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the deployments were added in the CSV by mistake.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aliok can you follow up on this? Since you did the actual Operator update, there might be some diff between your work, and my PR to the hub.

I can also close this now, and have you PR the ultimate solution

@aliok
Copy link
Copy Markdown
Contributor

aliok commented Feb 10, 2020

@matzew let's close this one in favor of #1210

@matzew
Copy link
Copy Markdown
Contributor Author

matzew commented Feb 10, 2020

/close

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@matzew: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. openshift-operator An Operator targeting OpenShift / OKD size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants