Skip to content
This repository was archived by the owner on Jul 30, 2021. It is now read-only.

Update Knative Kafka operator to 0.12.1#1210

Merged
J0zi merged 1 commit into
operator-framework:masterfrom
aliok:knative-kafka-operator-0.12.1
Feb 14, 2020
Merged

Update Knative Kafka operator to 0.12.1#1210
J0zi merged 1 commit into
operator-framework:masterfrom
aliok:knative-kafka-operator-0.12.1

Conversation

@aliok
Copy link
Copy Markdown
Contributor

@aliok aliok commented Feb 10, 2020

Signed-off-by: Ali Ok aliok@redhat.com

Thanks submitting your Operator. Please check below list before you create your Pull Request.


Flat operator directory structure is obsolete from 23-rd of October 2019, only nested directory structure will be accepted.


New Submissions

Updates to existing Operators

  • Is your new CSV pointing to the previous version with the replaces property?
  • Is your new CSV referenced in the appropriate channel defined in the package.yaml ?
  • Have you tested an update to your Operator when deployed via OLM?
  • Is your submission signed?

Your submission should not

  • Modify more than one operator
  • Modify an Operator you don't own
  • Rename an operator - please remove and add with a different name instead
  • Submit operators to both upstream-community-operators and community-operators at once
  • Modify any files outside the above mentioned folders
  • Contain more than one commit. Please squash your commits.

Operator Description must contain (in order)

  1. Description about the managed Application and where to find more information
  2. Features and capabilities of your Operator and how to use it
  3. Any manual steps about potential pre-requisites for using your Operator

Operator Metadata should contain

  • Human readable name and 1-liner description about your Operator
  • Valid category name1
  • One of the pre-defined capability levels2
  • Links to the maintainer, source code and documentation
  • Example templates for all Custom Resource Definitions intended to be used
  • A quadratic logo

Remember that you can preview your CSV here.

--

1 If you feel your Operator does not fit any of the pre-defined categories, file a PR against this repo and explain your need

2 For more information see here

@openshift-ci-robot openshift-ci-robot added openshift-operator An Operator targeting OpenShift / OKD size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2020
@matzew
Copy link
Copy Markdown
Contributor

matzew commented Feb 10, 2020

@aliok let's also add minKubeVersion: 1.15.0

@matzew
Copy link
Copy Markdown
Contributor

matzew commented Feb 10, 2020

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@matzew: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@J0zi J0zi self-assigned this Feb 11, 2020
@J0zi
Copy link
Copy Markdown
Collaborator

J0zi commented Feb 11, 2020

/ok-to-test

@openshift-ci-robot openshift-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 11, 2020
@J0zi
Copy link
Copy Markdown
Collaborator

J0zi commented Feb 11, 2020

/retest

@J0zi
Copy link
Copy Markdown
Collaborator

J0zi commented Feb 11, 2020

@aliok, failing on the following:
sync "test-operator" failed: {knative-kafka-operator-test null {test-operators openshift-marketplace}} not found: rpc error: code = Unknown desc = no entry found for knative-kafka-operator-test nul

@aliok
Copy link
Copy Markdown
Contributor Author

aliok commented Feb 11, 2020

thanks @J0zi I think I have gained good experience while debugging #1192 😄

I will ping you later when I fix this

@aliok aliok force-pushed the knative-kafka-operator-0.12.1 branch 2 times, most recently from 7131b13 to 73f8fe9 Compare February 12, 2020 12:02
@aliok
Copy link
Copy Markdown
Contributor Author

aliok commented Feb 12, 2020

/retest

Signed-off-by: Ali Ok <aliok@redhat.com>
@aliok aliok force-pushed the knative-kafka-operator-0.12.1 branch from 140191a to da0338a Compare February 13, 2020 09:39
@aliok
Copy link
Copy Markdown
Contributor Author

aliok commented Feb 13, 2020

@J0zi
I see this in operator-catalog-initialization check, not the failed one:

time="2020-02-13T09:46:31Z" level=info msg="could not decode contents of file /tmp/offline-cataloger/manifests-685891711/knative-kafka-operator/knative-kafka-operator.package.yaml into csv: error unmarshaling JSON: Object 'Kind' is missing in '{\"channels\":[{\"currentCSV\":\"knative-kafka-operator.v0.12.1\",\"name\":\"alpha\"}],\"packageName\":\"knative-kafka-operator\"}'" dir=/tmp/offline-cataloger/manifests-685891711 file=knative-kafka-operator.package.yaml load=bundles

Not sure what this means but I think this would be the root cause of the fail in the operator-olm-deployment step later.

could not decode contents of file .../knative-kafka-operator.package.yaml into csv --> why is it trying to decode the package into a csv?

BTW, I couldn't figure how to do these checks locally. The workflow for community-operators is different than upstream-community-operators and I couldn't find it anywhere.

@aliok
Copy link
Copy Markdown
Contributor Author

aliok commented Feb 13, 2020

@J0zi the checks finally passed now. not sure why they failed earlier.
let's merge this finally!

@matzew
Copy link
Copy Markdown
Contributor

matzew commented Feb 13, 2020

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@matzew: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matzew
Copy link
Copy Markdown
Contributor

matzew commented Feb 13, 2020

@dmesser mind to take a look here ?

@J0zi J0zi merged commit 3df5251 into operator-framework:master Feb 14, 2020
@aliok aliok deleted the knative-kafka-operator-0.12.1 branch February 14, 2020 07:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test. openshift-operator An Operator targeting OpenShift / OKD size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants