fix: (helm) - do not add owner references to resources that contain the Helm keep resource-policy annotation#71
Merged
joelanford merged 1 commit intomasterfrom Jan 15, 2021
Conversation
joelanford
force-pushed
the
feat/skip-ownerref-injection-on-keep
branch
5 times, most recently
from
458905d to
7daf1ff
Compare
joelanford
force-pushed
the
feat/skip-ownerref-injection-on-keep
branch
from
7daf1ff to
71cf6e6
Compare
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR build's on #70 (I will rebase when that merges).
Credit to @mikeshng for this (see operator-framework/operator-sdk#4389)
Description of the change:
Helm operator: updated the ownerRefInjectingClient to not inject the owner references if it contains the annotation:
see https://helm.sh/docs/howto/charts_tips_and_tricks/ for more details about the
keepannotation.Motivation for the change:
For the Helm operator delete CR, namespace scope resources with the Helm keep annotation are being GC'ed by Kubernetes.
This change is to make sure those resources are not owned by the CR so they won't get GC'ed.
Closes: operator-framework/operator-sdk#4378
After this change, I can no longer reproduces the issue described in operator-framework/operator-sdk#4378