fix: (helm) - do not add owner references to resources that contain the Helm keep resource-policy annotation

[mikeshng]

Signed-off-by: Mike Ng ming@redhat.com

Description of the change:
Helm operator: updated the ownerRefInjectingClient to not inject the owner references if it contains the annotation:

  annotations:
    "helm.sh/resource-policy": keep

see https://helm.sh/docs/howto/charts_tips_and_tricks/ for more details about the keep annotation.

Motivation for the change:
For the Helm operator delete CR, namespace scope resources with the Helm keep annotation are being GC'ed by Kubernetes.
This change is to make sure those resources are not owned by the CR so they won't get GC'ed.

Closes: #4378

After this change, I can no longer reproduces the issue described in #4378

Checklist

If the pull request includes user-facing changes, extra documentation is required:

• Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
• [NA] Add or update relevant sections of the docs website in website/content/en/docs

[mikeshng]

I followed the helm repo on how to check if the keep annotation exists.
https://github.com/helm/helm/blob/v3.4.2/pkg/action/resource_policy.go#L33-L40

[estroz]

Can you refactor this into a helper

Suggested change

	containsKeepAnno := false
	if u.GetAnnotations() != nil {
	resourcePolicyType, ok := u.GetAnnotations()[kube.ResourcePolicyAnno]
	if ok {
	resourcePolicyType = strings.ToLower(strings.TrimSpace(resourcePolicyType))
	containsKeepAnno = resourcePolicyType == kube.KeepPolicy
	}
	}
	if useOwnerRef && !containsKeepAnno {
	if useOwnerRef && !containsResourcePolicyKeep(u.GetAnnotations()) {

[mikeshng]

Done as suggested and added unit tests.

[joelanford]

Minor nit, but in order to minimize indentation, could you refactor to this?

Suggested change

	if annotations != nil {
	resourcePolicyType, ok := annotations[kube.ResourcePolicyAnno]
	if ok {
	resourcePolicyType = strings.ToLower(strings.TrimSpace(resourcePolicyType))
	return resourcePolicyType == kube.KeepPolicy
	}
	}
	return false
	if annotations == nil {
	return false
	}
	resourcePolicyType, ok := annotations[kube.ResourcePolicyAnno]
	if !ok {
	return false
	}
	resourcePolicyType = strings.ToLower(strings.TrimSpace(resourcePolicyType))
	return resourcePolicyType == kube.KeepPolicy

[mikeshng]

Done as suggested. Locally tested again and it seems fine.

[estroz]

/lgtm

[joelanford]

/lgtm