spread "fix: (helm) - do not add owner references to resources that contain the Helm keep resource-policy annotation #4389" to ansible-operator

[bas2k]

spread "fix: (helm) - do not add owner references to resources that contain the Helm keep resource-policy annotation #4389" for ansible-operator

Description of the change:
Spread "fix: (helm) - do not add owner references to resources that contain the Helm keep resource-policy annotation #4389" for ansible-operator

Motivation for the change:
We need such ability for ansible-operator, too.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

• Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
• Add or update relevant sections of the docs website in website/content/en/docs

[joelanford]

helm.sh/resource-policy: keep is a helm-specific annotation. I don't think we want to re-use this annotation in ansible operators.

We could talk about supporting a similar annotation for ansible though.

[joelanford]

/hold

[bas2k]

We're deploying helm charts along with doing other actions using ansible-operator and we're experiencing same issue as was fixed in #4389

[joelanford]

Yes, but if I understand this change correctly, then it means that ALL resources applied by an ansible operator would need to set a helm-specific annotation to prevent the injection of the owner reference, which seems wrong.

What I'm suggesting is that we teach the ansible operator about another similar annotation and use that when deciding whether to inject an owner reference.

In your case, you would then be able to include this annotation in your helm chart templates or potentially inject them as part of your ansible run.

[bas2k]

I see, that makes sense, thank you!

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.