Skip to content

Added new handler for metrics#8

Merged
jmrodri merged 1 commit intooperator-framework:mainfrom
jmrodri:add-metrics-handler
Jul 24, 2020
Merged

Added new handler for metrics#8
jmrodri merged 1 commit intooperator-framework:mainfrom
jmrodri:add-metrics-handler

Conversation

@jmrodri
Copy link
Copy Markdown
Member

@jmrodri jmrodri commented Jul 24, 2020

Moving instrumented_enqueue_object from operator-sdk:
operator-framework/operator-sdk#3436

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 24, 2020

Pull Request Test Coverage Report for Build 181337274

  • 0 of 34 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-7.6%) to 66.465%

Changes Missing Coverage Covered Lines Changed/Added Lines %
handler/instrumented_enqueue_object.go 0 34 0.0%
Totals Coverage Status
Change from base Build 181328012: -7.6%
Covered Lines: 220
Relevant Lines: 331

💛 - Coveralls

Copy link
Copy Markdown
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

After making just one fix.

Comment thread handler/metrics/metrics.go
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
Moving instrumented_enqueue_object from operator-sdk:
operator-framework/operator-sdk#3436
@jmrodri jmrodri force-pushed the add-metrics-handler branch from db47580 to 2ee1897 Compare July 24, 2020 15:18
@openshift-ci-robot
Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
@jmrodri jmrodri merged commit f4e8074 into operator-framework:main Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants