Add new handler for metrics#3436
Merged
bharathi-tenneti merged 1 commit intooperator-framework:masterfrom Jul 16, 2020
Merged
Conversation
bharathi-tenneti
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
bharathi-tenneti
added
language/ansible
Contributor
Author
|
Metrics output for Ansible and Helm sample operators correspondingly. # HELP primary_resource_created_at_seconds Timestamp at which a resource was created
# TYPE primary_resource_created_at_seconds gauge
primary_resource_created_at_seconds{group="cache.example.com",kind="Memcached",name="example-memcached",namespace="memcached",version="v1alpha1"} 1.594841815e+09# HELP primary_resource_created_at_seconds Timestamp at which a resource was created
# TYPE primary_resource_created_at_seconds gauge
primary_resource_created_at_seconds{group="cache.example.com",kind="Memcached",name="example-memcached",namespace="helm-memcached",version="v1alpha1"} 1.594843122e+09 |
joelanford
reviewed
Jul 15, 2020
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
Looks great. Just a few minor nits.
Member
|
We should probably document this metric somewhere in the helm and ansible docs as well. |
bharathi-tenneti
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
It shows great 🥇 Just a few nits.
Member
|
On second thought, let's add the tests in a follow-up. I've got a few other PRs I want to submit that depend on this merging. |
Contributor
Author
@joelanford @camilamacedo86 |
92 tasks
*Added changelog fragment
bharathi-tenneti
force-pushed
the
metrics_handler
branch
from
4c061ad to
82e78f4
Compare
camilamacedo86
approved these changes
Jul 16, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm
Since we agreed in do in a follow up the tests and docs improvements.
Great work 👍
jmrodri
added a commit
to jmrodri/operator-lib
that referenced
this pull request
Jul 24, 2020
Moving instrumented_enqueue_object from operator-sdk: operator-framework/operator-sdk#3436
jmrodri
added a commit
to jmrodri/operator-lib
that referenced
this pull request
Jul 24, 2020
Moving instrumented_enqueue_object from operator-sdk: operator-framework/operator-sdk#3436
jmrodri
added a commit
to operator-framework/operator-lib
that referenced
this pull request
Jul 24, 2020
Moving instrumented_enqueue_object from operator-sdk: operator-framework/operator-sdk#3436
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Add new handler for metrics which can be registered with controller-runtime registry, and wraps existing
EnqueueResuestForObject, for both Ansible and Helm controllers.Motivation: This PR addresses current complexity around exposing primary resource metrics in SDK.
/kind feature