pkg/sdk: implement sdk.Handle() API#11
Merged
hongchaodeng merged 1 commit intooperator-framework:masterfrom Feb 14, 2018
hasbro17:haseeb/register-handler
Merged
pkg/sdk: implement sdk.Handle() API#11hongchaodeng merged 1 commit intooperator-framework:masterfrom hasbro17:haseeb/register-handler
hongchaodeng merged 1 commit intooperator-framework:masterfrom
hasbro17:haseeb/register-handler
Conversation
|
|
||
| type Informer interface { | ||
| Run(ctx sdkTypes.Context) error | ||
| Run(ctx sdkTypes.Context, handler sdkTypes.Handler) error |
Contributor
There was a problem hiding this comment.
Informer should not be coupled to any handler?
Contributor
Author
There was a problem hiding this comment.
The pkg level handler is registered in pkg/sdk/api.go.
Instead of passing the hanlder to the informer I could add another sdk function to let the informer invoke the handler directly from the sdk package:
func CallHandler(ctx sdkTypes.Context, event sdkTypes.Event) []sdkTypes.Action {
return handler.Handle(ctx, event)
}Then the informer sync could just call the registered handler directly:
actions := sdk.CallHandler(i.ctx, event)
hasbro17
changed the title
hasbro17
changed the title
Contributor
|
LGTM |
fabianvf
pushed a commit
to fabianvf/operator-sdk
that referenced
this pull request
Jul 23, 2020
…-molecule Ansible plugin molecule
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the sdk.Handle() API and the related
Actiontype definition.The informer now invokes the handler.Handle() for an Event to get its Actions.