fix(ansible) : install jmespath in the contaner"#2252
Merged
jmrodri merged 3 commits intooperator-framework:masterfrom Nov 22, 2019
camilamacedo86:fix-jmespath
Merged
fix(ansible) : install jmespath in the contaner"#2252jmrodri merged 3 commits intooperator-framework:masterfrom camilamacedo86:fix-jmespath
jmrodri merged 3 commits intooperator-framework:masterfrom
camilamacedo86:fix-jmespath
Conversation
openshift-ci-robot
added
the
size/XS
camilamacedo86
added
language/ansible
openshift-ci-robot
added
the
size/S
camilamacedo86
requested review from
AlexNPavel,
asmacdo,
estroz,
jmccormick2001 and
joelanford
Member
|
/lgtm |
fabianvf
approved these changes
Nov 21, 2019
fabianvf
reviewed
Nov 21, 2019
| name: rpc | ||
|
|
||
| - name: Check if jmespath is installed | ||
| set_fact: |
Member
There was a problem hiding this comment.
Not a blocker, especially since this is just a test, but best practice to check for installed Python packages is to use the python_requirements_info module
camilamacedo86
added
the
approved
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Fix issue faced when jmespath queries are used in in the ansible tasks.
Motivation for the change:
Closes #2237