Skip to content

fix(ansible) : install jmespath in the contaner" #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmrodri merged 3 commits into from
Nov 22, 2019
Merged

fix(ansible) : install jmespath in the contaner" #2252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c4f4b0
fix(ansible) : install jmespath in the contaner"
camilamacedo86 Nov 21, 2019
d6a4d5d
CHANGELOG
camilamacedo86 Nov 21, 2019
8517301
add test
camilamacedo86 Nov 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
### Removed

### Bug Fixes
- Fix issue faced in the Ansible based operators when `jmespath` queries are used because it was not installed. ([#2252](https://github.com/operator-framework/operator-sdk/pull/2252))

## v0.12.0

Expand Down
1 change: 1 addition & 0 deletions ci/dockerfiles/ansible-e2e-hybrid.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ RUN yum clean all && rm -rf /var/cache/yum/* \
ansible-runner-http==1.0.0 \
openshift==0.8.9 \
ansible~=2.8 \
jmespath \
&& yum remove -y gcc python36-devel \
&& yum clean all \
&& rm -rf /var/cache/yum
Expand Down
1 change: 1 addition & 0 deletions ci/dockerfiles/ansible.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ RUN yum clean all && rm -rf /var/cache/yum/* \
ansible-runner-http==1.0.0 \
openshift==0.8.9 \
ansible~=2.8 \
jmespath \
&& yum remove -y gcc python36-devel \
&& yum clean all \
&& rm -rf /var/cache/yum
Expand Down
1 change: 1 addition & 0 deletions internal/scaffold/ansible/dockerfilehybrid.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ RUN yum clean all && rm -rf /var/cache/yum/* \
ansible-runner-http==1.0.0 \
openshift==0.8.9 \
ansible~=2.8 \
jmespath \
&& yum remove -y gcc python36-devel \
&& yum clean all \
&& rm -rf /var/cache/yum
Expand Down
6 changes: 6 additions & 0 deletions test/ansible-memcached/secret/tasks/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,9 @@
port: 8332
targetPort: 8332
name: rpc

- name: Check if jmespath is installed
set_fact:
Copy link
Copy Markdown
Member

@fabianvf fabianvf Nov 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, especially since this is just a test, but best practice to check for installed Python packages is to use the python_requirements_info module

instance_tags: '{{app | json_query(query)}}'
vars:
query: 'app[*]."memcached"'