Resources without generation will not skip events#2830
Merged
fabianvf merged 2 commits intooperator-framework:masterfrom Apr 14, 2020
Merged
Resources without generation will not skip events#2830fabianvf merged 2 commits intooperator-framework:masterfrom
fabianvf merged 2 commits intooperator-framework:masterfrom
Conversation
Fixes operator-framework#2108 If the `metadata.generation` is `0`, the event will now still trigger a reconciliation.
fabianvf
commented
Apr 13, 2020
| return false | ||
| } | ||
| if e.MetaNew.GetGeneration() == e.MetaOld.GetGeneration() { | ||
| if e.MetaNew.GetGeneration() == e.MetaOld.GetGeneration() && e.MetaNew.GetGeneration() != 0 { |
Member
Author
There was a problem hiding this comment.
I'm pretty sure that this will only happen if the metadata.generation is not set and therefore goes to the default integer value of 0 when queried.
joelanford
approved these changes
Apr 13, 2020
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
LGTM. We upstreamed this predicate, so we should make this change there as well... and we should deprecate this and switch.
Member
|
/lgtm |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2108
If the
metadata.generationis0, the event will now still trigger areconciliation.
Description of the change:
Motivation for the change: