Move pkg/predicate closer to where it is used.#3491
Closed
jmrodri wants to merge 2 commits intooperator-framework:masterfrom
Closed
Move pkg/predicate closer to where it is used.#3491jmrodri wants to merge 2 commits intooperator-framework:masterfrom
jmrodri wants to merge 2 commits intooperator-framework:masterfrom
Conversation
92 tasks
Member
|
Just double checking... Is the upstream predicate the same as the one the ansible operator was using? The ansible e2e test keeps failing. |
Member
Author
|
GenerationChangedPredicate is slightly different between the 2 implementations: The one in SDK https://github.com/operator-framework/operator-sdk/blob/master/pkg/predicate/predicate.go#L56-L59: And the one from controller-runtime is simpler https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/predicate/predicate.go#L181: So looks like by using the upstream version we introduced a regression fixed by PR #2830 and identified by Issue #2108. |
Member
Author
|
Closing in favor of PR #3532 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Move
pkg/predicateto theansiblepackage because it is not used anywhere else.Motivation for the change:
Since this package is not used outside the ansible package, it makes sense to have it co-located. In the future we hope to move it to
operator-liborcontroller-runtime.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs