Skip to content

pkg/predicate: move predicates elsewhere and remove#3532

Merged
estroz merged 1 commit intooperator-framework:masterfrom
estroz:chore/update-pkg-predicate
Jul 24, 2020
Merged

pkg/predicate: move predicates elsewhere and remove#3532
estroz merged 1 commit intooperator-framework:masterfrom
estroz:chore/update-pkg-predicate

Conversation

@estroz
Copy link
Copy Markdown
Member

@estroz estroz commented Jul 24, 2020

Description of the change:

  • pkg/predicate: remove
  • pkg/ansible/predicate: move ResourceFilterPredicate here
  • pkg/predicate: GenerationChangedPredicate to operator-lib

Motivation for the change: public code cleanup

/cc @jmrodri @joelanford

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Comment thread go.mod
Copy link
Copy Markdown
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
…e, GenerationChangedPredicate to operator-lib
@estroz estroz force-pushed the chore/update-pkg-predicate branch from fbff32d to 976b1ae Compare July 24, 2020 22:39
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

New changes are detected. LGTM label has been removed.

@estroz estroz merged commit 6419773 into operator-framework:master Jul 24, 2020
@estroz estroz deleted the chore/update-pkg-predicate branch July 24, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants