Makefile,hack/image: build and release targets for helm and ansible binaries #3363
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| entries: | ||
| - description: > | ||
| Add builds for `ansible-operator` and `helm-operator` binaries | ||
| kind: addition | ||
| breaking: false |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,15 +12,12 @@ BASEIMAGEDIR="$TMPDIR/ansible-operator" | |
| mkdir -p "$BASEIMAGEDIR" | ||
| go build -o $BASEIMAGEDIR/scaffold-ansible-image ./hack/image/ansible/scaffold-ansible-image.go | ||
|
|
||
| # build operator binary and base image | ||
| pushd "$BASEIMAGEDIR" | ||
| ./scaffold-ansible-image | ||
|
|
||
| mkdir -p build/_output/bin/ | ||
| cp $ROOTDIR/build/ansible-operator-dev-linux-gnu build/_output/bin/ansible-operator | ||
| operator-sdk build $1 | ||
| # If using a kind cluster, load the image into all nodes. | ||
| load_image_if_kind "$1" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,15 +12,12 @@ BASEIMAGEDIR="$TMPDIR/helm-operator" | |
| mkdir -p "$BASEIMAGEDIR" | ||
| go build -o $BASEIMAGEDIR/scaffold-helm-image ./hack/image/helm/scaffold-helm-image.go | ||
|
|
||
| # build operator binary and base image | ||
| pushd "$BASEIMAGEDIR" | ||
| ./scaffold-helm-image | ||
|
|
||
| mkdir -p build/_output/bin/ | ||
| cp $ROOTDIR/build/helm-operator-dev-linux-gnu build/_output/bin/helm-operator | ||
| operator-sdk build $1 | ||
| # If using a kind cluster, load the image into all nodes. | ||
| load_image_if_kind "$1" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,33 +18,45 @@ $ brew install operator-sdk | |
|
|
||
| ## Install from GitHub release | ||
|
|
||
| ### Download the release binaries | ||
|
|
||
| ```sh | ||
| # Set the release version variable | ||
| $ RELEASE_VERSION=v0.18.0 | ||
| # Linux | ||
| $ curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/operator-sdk-${RELEASE_VERSION}-x86_64-linux-gnu | ||
| $ curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/ansible-operator-${RELEASE_VERSION}-x86_64-linux-gnu | ||
| $ curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/helm-operator-${RELEASE_VERSION}-x86_64-linux-gnu | ||
| # macOS | ||
| $ curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/operator-sdk-${RELEASE_VERSION}-x86_64-apple-darwin | ||
| $ curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/ansible-operator-${RELEASE_VERSION}-x86_64-apple-darwin | ||
| $ curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/helm-operator-${RELEASE_VERSION}-x86_64-apple-darwin | ||
| ``` | ||
|
|
||
| #### Verify the downloaded release binaries | ||
|
|
||
| ```sh | ||
| # Linux | ||
| $ curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/operator-sdk-${RELEASE_VERSION}-x86_64-linux-gnu.asc | ||
| $ curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/ansible-operator-${RELEASE_VERSION}-x86_64-linux-gnu.asc | ||
| $ curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/helm-operator-${RELEASE_VERSION}-x86_64-linux-gnu.asc | ||
| # macOS | ||
| $ curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/operator-sdk-${RELEASE_VERSION}-x86_64-apple-darwin.asc | ||
| $ curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/ansible-operator-${RELEASE_VERSION}-x86_64-apple-darwin.asc | ||
| $ curl -LO https://github.com/operator-framework/operator-sdk/releases/download/${RELEASE_VERSION}/helm-operator-${RELEASE_VERSION}-x86_64-apple-darwin.asc | ||
| ``` | ||
|
|
||
| To verify a release binary using the provided asc files, place the binary and corresponding asc file into the same directory and use the corresponding command: | ||
|
|
||
| ```sh | ||
| # Linux | ||
| $ gpg --verify operator-sdk-${RELEASE_VERSION}-x86_64-linux-gnu.asc | ||
| $ gpg --verify ansible-operator-${RELEASE_VERSION}-x86_64-linux-gnu.asc | ||
| $ gpg --verify helm-operator-${RELEASE_VERSION}-x86_64-linux-gnu.asc | ||
| # macOS | ||
| $ gpg --verify operator-sdk-${RELEASE_VERSION}-x86_64-apple-darwin.asc | ||
| $ gpg --verify ansible-operator-${RELEASE_VERSION}-x86_64-apple-darwin.asc | ||
| $ gpg --verify helm-operator-${RELEASE_VERSION}-x86_64-apple-darwin.asc | ||
| ``` | ||
|
|
||
| If you do not have the maintainers public key on your machine, you will get an error message similar to this: | ||
|
|
@@ -76,8 +88,12 @@ Now you should be able to verify the binary. | |
| ```sh | ||
| # Linux | ||
| $ chmod +x operator-sdk-${RELEASE_VERSION}-x86_64-linux-gnu && sudo mkdir -p /usr/local/bin/ && sudo cp operator-sdk-${RELEASE_VERSION}-x86_64-linux-gnu /usr/local/bin/operator-sdk && rm operator-sdk-${RELEASE_VERSION}-x86_64-linux-gnu | ||
| $ chmod +x ansible-operator-${RELEASE_VERSION}-x86_64-linux-gnu && sudo mkdir -p /usr/local/bin/ && sudo cp ansible-operator-${RELEASE_VERSION}-x86_64-linux-gnu /usr/local/bin/ansible-operator && rm ansible-operator-${RELEASE_VERSION}-x86_64-linux-gnu | ||
| $ chmod +x helm-operator-${RELEASE_VERSION}-x86_64-linux-gnu && sudo mkdir -p /usr/local/bin/ && sudo cp helm-operator-${RELEASE_VERSION}-x86_64-linux-gnu /usr/local/bin/helm-operator && rm helm-operator-${RELEASE_VERSION}-x86_64-linux-gnu | ||
| # macOS | ||
| $ chmod +x operator-sdk-${RELEASE_VERSION}-x86_64-apple-darwin && sudo mkdir -p /usr/local/bin/ && sudo cp operator-sdk-${RELEASE_VERSION}-x86_64-apple-darwin /usr/local/bin/operator-sdk && rm operator-sdk-${RELEASE_VERSION}-x86_64-apple-darwin | ||
| $ chmod +x ansible-operator-${RELEASE_VERSION}-x86_64-apple-darwin && sudo mkdir -p /usr/local/bin/ && sudo cp ansible-operator-${RELEASE_VERSION}-x86_64-apple-darwin /usr/local/bin/ansible-operator && rm ansible-operator-${RELEASE_VERSION}-x86_64-apple-darwin | ||
| $ chmod +x helm-operator-${RELEASE_VERSION}-x86_64-apple-darwin && sudo mkdir -p /usr/local/bin/ && sudo cp helm-operator-${RELEASE_VERSION}-x86_64-apple-darwin /usr/local/bin/helm-operator && rm helm-operator-${RELEASE_VERSION}-x86_64-apple-darwin | ||
| ``` | ||
|
|
||
| ## Compile and install from master | ||
|
|
@@ -95,6 +111,8 @@ $ cd operator-sdk | |
| $ git checkout master | ||
| $ make tidy | ||
| $ make install | ||
| $ make install-ansible | ||
| $ make install-helm | ||
| ``` | ||
|
|
||
| **Note:** Ensure that your `GOPROXY` is set with its default value for Go | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this more specific?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that, but it resulted in a weird build error I couldn't figure out how to solve. I'm not a Makefile guru by any means though, so suggestions welcome.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the above to specify the right target (That still doesn't work. Let me look into this.$%).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a blocker, just a cosmetic nit.