Makefile,hack/image: build and release targets for helm and ansible binaries#3363
Merged
joelanford merged 1 commit intooperator-framework:masterfrom Jul 8, 2020
Conversation
estroz
reviewed
Jul 8, 2020
| build/helm-operator-%-s390x-linux-gnu: GOARGS = GOOS=linux GOARCH=s390x | ||
| build/helm-operator-%-linux-gnu: GOARGS = GOOS=linux | ||
|
|
||
| build/operator-%: $(SOURCES) ## Build the operator-sdk binary |
Member
There was a problem hiding this comment.
Can we make this more specific?
Suggested change
| build/operator-%: $(SOURCES) ## Build the operator-sdk binary | |
| build/operator-sdk$%: $(SOURCES) ## Build the operator-sdk binary |
Member
Author
There was a problem hiding this comment.
I tried that, but it resulted in a weird build error I couldn't figure out how to solve. I'm not a Makefile guru by any means though, so suggestions welcome.
Member
There was a problem hiding this comment.
Fixed the above to specify the right target ( That still doesn't work. Let me look into this.$%).
Member
There was a problem hiding this comment.
This is not a blocker, just a cosmetic nit.
estroz
reviewed
Jul 8, 2020
| build/operator-%: $(SOURCES) ## Build the operator-sdk binary | ||
| $(Q)$(GOARGS) go build $(GO_BUILD_ARGS) -o $@ $(SDK_BUILD_PATH) | ||
|
|
||
| build/ansible-%: $(SOURCES) ## Build the ansible-operator binary |
Member
There was a problem hiding this comment.
Can we make this more specific? Ditto for helm.
Suggested change
| build/ansible-%: $(SOURCES) ## Build the ansible-operator binary | |
| build/ansible-operator%: $(SOURCES) ## Build the ansible-operator binary |
camilamacedo86
approved these changes
Jul 8, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm /approve.
I am ok with 👍 / Also, I understand that it will be moved to be done in the ansible/helm repo as well when they exist.
varshaprasad96
approved these changes
Jul 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Add build targets and rules for the
ansible-operatorandhelm-operatorbinariesMotivation for the change:
For 1.0, we want to remove the
operator-sdk run localcommand. To continue supporting running helm and ansible operators locally, we will need these binaries to be released so that upcomingmake runtargets for those operator types can download and run the operator binaries locally.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs