feat: allow know the project type by the config file#3330
Merged
camilamacedo86 merged 2 commits intooperator-framework:masterfrom Jul 10, 2020
camilamacedo86:run-local-for-new
Merged
feat: allow know the project type by the config file#3330camilamacedo86 merged 2 commits intooperator-framework:masterfrom camilamacedo86:run-local-for-new
camilamacedo86 merged 2 commits intooperator-framework:masterfrom
camilamacedo86:run-local-for-new
Conversation
camilamacedo86
added
kubebuilder-integration
camilamacedo86
commented
Jul 1, 2020
| } | ||
| return "" | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
move the implementation to the project util since is required/useful to check the project type.
tengqm
reviewed
Jul 2, 2020
This was referenced Jul 3, 2020
asmacdo
approved these changes
Jul 6, 2020
Member
asmacdo
left a comment
asmacdo
left a comment
There was a problem hiding this comment.
Some of this logic could be DRYer, but while we support the legacy layouts, this is fine.
estroz
suggested changes
Jul 6, 2020
| } | ||
| return PluginKeyToOperatorType(cfg.Layout) == OperatorTypeAnsible | ||
| } | ||
| // todo(camilamacedo86): remove when the legacy layout is no longer supported |
Member
There was a problem hiding this comment.
Will the roles dir no longer be in the new layout?
Contributor
Author
There was a problem hiding this comment.
The roles dir will be in the new layout, however, see:
- Follow up the same standard for all types shows very beneficial and increase the manutence ability
- We can init an Ansible/Helm project without scaffold an API which means that the roles dir would NOT exist.
| } | ||
| return PluginKeyToOperatorType(cfg.Layout) == OperatorTypeHelm | ||
| } | ||
| // todo(camilamacedo86): remove when the legacy layout is no longer supported |
Member
There was a problem hiding this comment.
Will the charts dir no longer be in the new layout?
Contributor
Author
There was a problem hiding this comment.
ditto above. We can scaffold a project without any api.
Member
|
@camilamacedo86 now that we have #3363 and #3371, is this PR still needed? |
Contributor
Author
|
Hi @joelanford, The changes to allow the project type helpers get the type based in the config file for the new layout still required. |
camilamacedo86
changed the title
2 tasks
estroz
reviewed
Jul 10, 2020
Co-authored-by: Eric Stroczynski <estroczy@redhat.com>
|
New changes are detected. LGTM label has been removed. |
joelanford
pushed a commit
to joelanford/operator-sdk
that referenced
this pull request
Jul 13, 2020
…ork#3330) **Description of the change:** - Make ProjectTypes helpers looking for the type in the PROJECT file when it exists. **Motivation for the change:** - To allow the SDK CLI commands works properly for the new layout - Follow up the same standard for all types shows very beneficial and increase the manutence ability
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change: