Makefile: fix build/% rule#3371
Merged
joelanford merged 1 commit intooperator-framework:masterfrom Jul 9, 2020
Merged
Conversation
|
New changes are detected. LGTM label has been removed. |
camilamacedo86
approved these changes
Jul 9, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
Tested locally 👍
/lgtm /approve
Just a nit we replaced all / for "-" so I think we should keep the same standard.
|
|
||
| build/helm-%: $(SOURCES) ## Build the helm-operator binary | ||
| $(Q)$(GOARGS) go build $(GO_BUILD_ARGS) -o $@ $(HELM_BUILD_PATH) | ||
| build/%: $(SOURCES) ## Build the operator-sdk binary |
Contributor
There was a problem hiding this comment.
I think we would need replace it as:
Suggested change
| build/%: $(SOURCES) ## Build the operator-sdk binary | |
| build-%: $(SOURCES) ## Build the operator-sdk binary |
Member
Author
|
@camilamacedo86 the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Parse package name out of binary
build/%target.Motivation for the change:
Simplify build target and don't stomp out
build/%.asctarget.