Remove legacy generate and bundle commands#3414
Merged
hasbro17 merged 2 commits intooperator-framework:masterfrom Jul 17, 2020
Merged
Remove legacy generate and bundle commands#3414hasbro17 merged 2 commits intooperator-framework:masterfrom
hasbro17 merged 2 commits intooperator-framework:masterfrom
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
needs-rebase
92 tasks
estroz
reviewed
Jul 14, 2020
| @@ -51,7 +51,6 @@ More information about the integration with OLM via SDK: | |||
| https://sdk.operatorframework.io/docs/olm-integration/legacy | |||
| ` | |||
| cmd.AddCommand( | |||
Member
There was a problem hiding this comment.
You can remove the entire bundle subcommand for legacy projects.
estroz
reviewed
Jul 14, 2020
| @@ -1,261 +0,0 @@ | |||
| // Copyright 2019 The Operator-SDK Authors | |||
Member
There was a problem hiding this comment.
This package still needs to stick around for the new CSV bases to work. #2792 should be updated to remove these. You can just leave this package in internal/generate/olm-catalog/descriptor for now.
2 tasks
hasbro17
force-pushed
the
remove-gen-csv
branch
2 times, most recently
from
22108bb to
ad78b43
Compare
openshift-ci-robot
removed
the
needs-rebase
hasbro17
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
Removed legacy "generate csv/packagemanifests/bundle", and "bundle create/validate" commands. Also removed associated scaffolding packages for these commands in "internal/generate/olm-catalog".
estroz
reviewed
Jul 16, 2020
estroz
reviewed
Jul 16, 2020
estroz
approved these changes
Jul 16, 2020
camilamacedo86
approved these changes
Jul 16, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm
It shows great for me 👍
I cannot see anything else that is missing get done here.
varshaprasad96
approved these changes
Jul 16, 2020
Member
varshaprasad96
left a comment
varshaprasad96
left a comment
There was a problem hiding this comment.
Checked out by running with these changes locally.
/lgtm
Contributor
Author
|
Thanks for the quick reviews everyone. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Removed the following legacy cmds:
generate csvgenerate packagemanifestsgenerate bundlebundle createbundle validateAlso removed associated scaffolding packages for these commands in
internal/generate/olm-catalog.Motivation for the change:
From #3327 : Prepare SDK CLI for
1.0.0releaseTODO:
run packagemanifestscmd usinginternal/generate/olm-catalog.Remove legacy OLM integration docs_ https://sdk.operatorframework.io/docs/olm-integration/legacy/generate bundlecmdbundle <create/validate>cmd