Skip to content

test/test-framework: remove, and update/remove references and dependent tests#3424

Merged
estroz merged 1 commit intooperator-framework:masterfrom
estroz:refactor/remove-test-framework
Jul 15, 2020
Merged

test/test-framework: remove, and update/remove references and dependent tests#3424
estroz merged 1 commit intooperator-framework:masterfrom
estroz:refactor/remove-test-framework

Conversation

@estroz
Copy link
Copy Markdown
Member

@estroz estroz commented Jul 14, 2020

Description of the change:

  • test/test-framework: removed
  • *: remove references to the test-framework project or remove legacy tests using it

Motivation for the change: This PR removes the test/test-framework sample project used for internal testing, and updates or removes any referent legacy tests. This is part of a greater effort to remove legacy code to prepare for v1.0. See #3327 for details.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@estroz
Copy link
Copy Markdown
Member Author

estroz commented Jul 14, 2020

@hasbro17 this removes bundle create and legacy generate subcommand test scripts, which you also will likely remove in #3414. If this merges first then you do not have to remove these scripts.

@estroz estroz force-pushed the refactor/remove-test-framework branch 2 times, most recently from bd44a70 to 74d943c Compare July 14, 2020 22:54
Comment thread hack/lib/common.sh
Comment thread hack/lib/test_lib.sh
Comment thread hack/tests/integration.sh Outdated
source hack/lib/image_lib.sh

export OSDK_INTEGRATION_IMAGE="quay.io/example/memcached-operator:latest"
TMPDIR="$(mktemp -d memcached-XXXX)"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires to be XXXX? Could not be a name related to the test?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XXXX is a template string which will be substituted with random characters. See mktemp -h for more info.

Comment thread test/integration/integration_helpers.go Outdated
@estroz estroz force-pushed the refactor/remove-test-framework branch 2 times, most recently from 6a498d4 to f856b31 Compare July 15, 2020 03:02
@estroz estroz added this to the v1.0.0 milestone Jul 15, 2020
@estroz estroz force-pushed the refactor/remove-test-framework branch from f856b31 to 117ba11 Compare July 15, 2020 03:08
internal testing, and updates or removes any referent legacy tests.

test/test-framework: remove

*: remove references to the test-framework project or remove legacy
tests using it
@estroz estroz force-pushed the refactor/remove-test-framework branch from 117ba11 to e154026 Compare July 15, 2020 04:22
@joelanford joelanford mentioned this pull request Jul 15, 2020
92 tasks
Copy link
Copy Markdown
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2020
@estroz estroz merged commit 96d8bae into operator-framework:master Jul 15, 2020
@estroz estroz deleted the refactor/remove-test-framework branch July 15, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants