ansible: rename cmd line flag and add global variable#3435
Merged
varshaprasad96 merged 1 commit intooperator-framework:masterfrom Jul 16, 2020
Merged
Conversation
varshaprasad96
commented
Jul 15, 2020
| w.Vars = tmp.Vars | ||
| w.MaxRunnerArtifacts = tmp.MaxRunnerArtifacts | ||
| w.MaxWorkers = getMaxWorkers(gvk, maxWorkersDefault) | ||
| w.MaxWorkers = getMaxReconciles(gvk, maxReconcilesDefault) |
Member
Author
There was a problem hiding this comment.
Will modify the variable naming for watches in a follow up PR along with helm modifications.
joelanford
reviewed
Jul 15, 2020
varshaprasad96
force-pushed
the
ansible/mod-operator-flag
branch
2 times, most recently
from
f94a406 to
28e31e6
Compare
joelanford
approved these changes
Jul 16, 2020
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
LGTM after one minor fix and passing CI.
varshaprasad96
force-pushed
the
ansible/mod-operator-flag
branch
2 times, most recently
from
4017fe3 to
91badcc
Compare
camilamacedo86
approved these changes
Jul 16, 2020
Contributor
camilamacedo86
left a comment
camilamacedo86
left a comment
There was a problem hiding this comment.
/lgtm
great work 🥇
This commit: * Deprecates --max-workers flag * Adds --max-concurrent-reconciles flag * Adds MAX_CONCURRENT_RECONCILES_<group>_<kind> global variable * Update relevant documentation
varshaprasad96
force-pushed
the
ansible/mod-operator-flag
branch
from
91badcc to
60dea10
Compare
|
New changes are detected. LGTM label has been removed. |
2 tasks
92 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
This PR:
Motivation for the change:
Effort to change ansible operator flags to match controller-runtime constructs.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs