fix: remove max-workers flag for ansible#3456
Merged
varshaprasad96 merged 1 commit intooperator-framework:masterfrom Jul 20, 2020
Merged
fix: remove max-workers flag for ansible#3456varshaprasad96 merged 1 commit intooperator-framework:masterfrom
varshaprasad96 merged 1 commit intooperator-framework:masterfrom
Conversation
Removes max-workers flag for ansible operators. They have been replaced by --max-concurrent-reconciles.
Member
Author
|
Intentionally didn't add a changelog fragment here, because we already have a fragment for this in #3435 . But the changelog there says, its an addition for the flag instead of renaming. Can we create a separate PR for changing that, or can that be modified manually later? @joelanford |
Member
|
@varshaprasad96 we can submit another PR to update the changelog fragment. |
92 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Removes max-workers flag for ansible operators. They have been
replaced by --max-concurrent-reconciles.
Motivation for the change:
Follow up of #3435 on changing an implementation.
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs