cmd/helm-operator/main.go: add --metrics-addr flag#3440
cmd/helm-operator/main.go: add --metrics-addr flag#3440joelanford merged 4 commits intooperator-framework:masterfrom
Conversation
04fa722 to
cb9cc23
Compare
camilamacedo86
left a comment
There was a problem hiding this comment.
Just a nit in the fragment. Otherwise, it shows great
/lgtm
| migration: | ||
| header: Default helm operator metrics port changed | ||
| body: > | ||
| To continue using port 8383, specify `--metrics-addr=:8383` when you start the operator. |
There was a problem hiding this comment.
WDYT about we improve it and describe where the --metrics-addr=:8383 need to be used (config/default, and config/manager/)?
There was a problem hiding this comment.
I disagree for a few reasons:
- In general, it should be obvious to most operator authors, and kubernetes users how to set flags on their operator.
- In fairness, it is somewhat confusing when kustomize enters the picture, so I would propose that we write a general section in a doc somewhere about how to set flags on the manager when using the kustomize templates. This should probably be a kubebuidler doc.
- There are lots of flags on operators. We shouldn't have to repeat ourselves in migration guides, docs, etc. anytime we discuss setting flags.
cb9cc23 to
33139ed
Compare
|
New changes are detected. LGTM label has been removed. |
b8fe2c1 to
79e3882
Compare
| - args: | ||
| - manager |
There was a problem hiding this comment.
This removal is no directly related to this PR, but needs to happen to avoid problems running the operator in a cluster.
This is an accidental carryover from Go operators that have a manager binary. But helm-operator has a different binary entrypoint: the base image adds the binary and sets the entrypoint for us, so we just need to specify the flags to pass to the helm-operator binary.
Description of the change:
Add
--metrics-addrflag for Helm operatorMotivation for the change:
#2451 #3358
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs