Remove pkg/metrics and pkg/kube-metrics#3484
Merged
bharathi-tenneti merged 4 commits intooperator-framework:masterfrom Jul 22, 2020
Merged
Remove pkg/metrics and pkg/kube-metrics#3484bharathi-tenneti merged 4 commits intooperator-framework:masterfrom
bharathi-tenneti merged 4 commits intooperator-framework:masterfrom
Conversation
openshift-ci-robot
added
lgtm
joelanford
approved these changes
Jul 22, 2020
Member
joelanford
left a comment
joelanford
left a comment
There was a problem hiding this comment.
/lgtm
After reverting the added indirect requires (if possible)
hasbro17
force-pushed
the
remove-pkg-metrics
branch
from
51744bd to
303e935
Compare
hasbro17
force-pushed
the
remove-pkg-metrics
branch
from
303e935 to
e8fd63e
Compare
joelanford
reviewed
Jul 22, 2020
|
|
||
| require ( | ||
| github.com/blang/semver v3.5.1+incompatible | ||
| github.com/coreos/prometheus-operator v0.38.1-0.20200424145508-7e176fda06cc |
Member
There was a problem hiding this comment.
I feel like I remember this dependency being the one that forced us to use replace for k8s.io/client-go. Can you see if we can directly require k8s.io/client-go v0.18.2 now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Remove
pkg/metricsandpkg/kube-metricsas they are no longer being used by any of the operator scaffolds after #3466Motivation for the change:
Removing unused public APIs to prepare for the
v1.0.0release #3327