Skip to content

Remove pkg/metrics and pkg/kube-metrics #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bharathi-tenneti merged 4 commits into from
Jul 22, 2020
Merged

Remove pkg/metrics and pkg/kube-metrics #3484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff782d3
Remove pkg/metrics and pkg/kube-metrics
hasbro17 Jul 22, 2020
e8fd63e
update go.mod
hasbro17 Jul 22, 2020
83e3df3
Add k8s.io/client-go v0.18.2 to require section
bharathi-tenneti Jul 22, 2020
7b47a18
Run go mod tidy
bharathi-tenneti Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions changelog/fragments/rm-pkg-kube-metrics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# entries is a list of entries to include in
# release notes and/or the migration guide
entries:
- description: >
Removed `pkg/kube-metrics` and its associated helpers `NewNamespacedMetricsStores()`,
`NewClusterScopedMetricsStores()`, `ServeMetrics()`, and `GenerateAndServeCRMetrics()`.

kind: "removal"

breaking: true

migration:
header: Removed `pkg/kube-metrics`
body: >
TBD
15 changes: 15 additions & 0 deletions changelog/fragments/rm-pkg-metrics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# entries is a list of entries to include in
# release notes and/or the migration guide
entries:
- description: >
Removed `pkg/metrics` and its helpers "GenerateAndServeCRMetrics()" and
"GetNamespacesForMetrics()".

kind: "removal"

breaking: true

migration:
header: Removed `pkg/metrics`
body: >
TBD
5 changes: 1 addition & 4 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ go 1.13

require (
github.com/blang/semver v3.5.1+incompatible
github.com/coreos/prometheus-operator v0.38.1-0.20200424145508-7e176fda06cc
Copy link
Copy Markdown
Member

@joelanford joelanford Jul 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like I remember this dependency being the one that forced us to use replace for k8s.io/client-go. Can you see if we can directly require k8s.io/client-go v0.18.2 now?

github.com/fatih/structtag v1.1.0
github.com/go-logr/logr v0.1.0
github.com/go-logr/zapr v0.1.1
Expand Down Expand Up @@ -37,10 +36,9 @@ require (
k8s.io/apiextensions-apiserver v0.18.2
k8s.io/apimachinery v0.18.2
k8s.io/cli-runtime v0.18.2
k8s.io/client-go v12.0.0+incompatible
k8s.io/client-go v0.18.2
k8s.io/gengo v0.0.0-20200114144118-36b2048a9120
k8s.io/klog v1.0.0
k8s.io/kube-state-metrics v1.7.2
k8s.io/kubectl v0.18.2
rsc.io/letsencrypt v0.0.3 // indirect
sigs.k8s.io/controller-runtime v0.6.0
Expand All @@ -52,5 +50,4 @@ require (
replace (
github.com/Azure/go-autorest => github.com/Azure/go-autorest v13.3.2+incompatible // Required by OLM
github.com/mattn/go-sqlite3 => github.com/mattn/go-sqlite3 v1.10.0
k8s.io/client-go => k8s.io/client-go v0.18.2
)
385 changes: 12 additions & 373 deletions go.sum
View file
Open in desktop

Large diffs are not rendered by default.

143 changes: 0 additions & 143 deletions pkg/kube-metrics/metrics.go
View file
Open in desktop

This file was deleted.

76 changes: 0 additions & 76 deletions pkg/kube-metrics/server.go
View file
Open in desktop

This file was deleted.

Loading