Remove operator-sdk new|add api commands and ansible scaffolding.

[varshaprasad96]

Description of the change:
Remove operator-sdk new|add api commands and ansible scaffolding.
This commit does the following:

1. Remove operator-sdk new and operator-sdk add api in favour of ansible plugins.
2. Remove ansible scaffolding (ie) internal/scaffold/ansible.
3. Remove internal/flags/apiflags/flags.go and relevant tests which were used in the commands.
4. Update IsOperatorAnsible() to check only for new layouts.
5. Remove reference to new|add api commands in cli.

Motivation for the change:
Remove support for legacy commands and layouts in Operator SDK 1.0

Things to-do in follow up PR:

1. Remove operator-sdk add crd and relevant crd generator code/its tests which are not used.
2. Remove legacy cli support from cmd/operator-sdk/main.go

c/c @joelanford @jmrodri @camilamacedo86 @fabianvf

Summary of changes:

A       changelog/fragments/rm-cmd-legacy-ansible.yaml
D       cmd/operator-sdk/add/api.go
M       cmd/operator-sdk/add/cmd.go
M       cmd/operator-sdk/cli/cli.go
M       cmd/operator-sdk/cli/legacy.go
M       cmd/operator-sdk/main.go
D       cmd/operator-sdk/new/cmd.go
M       hack/tests/e2e-ansible.sh
D       internal/flags/apiflags/flags.go
D       internal/flags/apiflags/flags_test.go
D       internal/scaffold/ansible/OWNERS
D       internal/scaffold/ansible/build_dockerfile.go
D       internal/scaffold/ansible/constants.go
D       internal/scaffold/ansible/deploy_operator.go
D       internal/scaffold/ansible/input.go
D       internal/scaffold/ansible/molecule_cluster_converge.go
D       internal/scaffold/ansible/molecule_cluster_create.go
D       internal/scaffold/ansible/molecule_cluster_destroy.go
D       internal/scaffold/ansible/molecule_cluster_molecule.go
D       internal/scaffold/ansible/molecule_cluster_prepare.go
D       internal/scaffold/ansible/molecule_cluster_verify.go
D       internal/scaffold/ansible/molecule_default_converge.go
D       internal/scaffold/ansible/molecule_default_molecule.go
D       internal/scaffold/ansible/molecule_default_prepare.go
D       internal/scaffold/ansible/molecule_default_verify.go
D       internal/scaffold/ansible/molecule_templates_operator.go
D       internal/scaffold/ansible/molecule_test_local_converge.go
D       internal/scaffold/ansible/molecule_test_local_molecule.go
D       internal/scaffold/ansible/molecule_test_local_prepare.go
D       internal/scaffold/ansible/molecule_test_local_verify.go
D       internal/scaffold/ansible/playbook.go
D       internal/scaffold/ansible/requirements.go
D       internal/scaffold/ansible/roles_defaults_main.go
D       internal/scaffold/ansible/roles_files.go
D       internal/scaffold/ansible/roles_handlers_main.go
D       internal/scaffold/ansible/roles_meta_main.go
D       internal/scaffold/ansible/roles_readme.go
D       internal/scaffold/ansible/roles_tasks_main.go
D       internal/scaffold/ansible/roles_templates.go
D       internal/scaffold/ansible/roles_vars_main.go
D       internal/scaffold/ansible/testdata/invalid/emptywatchfile/watches.yaml
D       internal/scaffold/ansible/testdata/invalid/invalid_watch/watches.yaml
D       internal/scaffold/ansible/testdata/valid1/validWatches.yaml
D       internal/scaffold/ansible/testdata/valid2/validWatches.yaml
D       internal/scaffold/ansible/travis.go
D       internal/scaffold/ansible/watches.go
D       internal/scaffold/ansible/watches_test.go
M       internal/util/projutil/project_util.go
M       website/content/en/docs/cli/operator-sdk.md
D       website/content/en/docs/cli/operator-sdk_new.md

Checklist

If the pull request includes user-facing changes, extra documentation is required:

• Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
• Add or update relevant sections of the docs website in website/content/en/docs

[varshaprasad96]

Leaving install set up here, thought not necessary.

[joelanford]

/lgtm

[camilamacedo86]

We can remove the full file and target.

[camilamacedo86]

but do not need to do it in this PR we can do in a follow-up. Let's save Travis cycles.

[camilamacedo86]

Shows that we can remove all: /operator-sdk/internal/scaffold/
Required check if has some part of code which will require it.

[varshaprasad96]

Some of it is still used while scaffolding kustomize templates (eg: in generate/kustomize/manifests.go) and in add crd.
With the removal of add crd, Ill clean up internal/scaffold too.

[camilamacedo86]

/lgtm

You can remove it if pass in the CI and then we can do follow-ups with what can be missing here👍

[asmacdo]

@fabianvf since you are modifying this file for the ansible-plugin, I assume @varshaprasad96 should leave this file untouched?

[fabianvf]

correct

[fabianvf]

they've been rewritten in the scaffold PR, this will just cause a conflict

[varshaprasad96]

Ill add this, and comment the targets in Makefile where its called.

[joelanford]

e2e tests will fail if the scaffolding is removed. so we either need to block this PR on the plugin PR

Or have the plugin PR rebase and re-add these tests.

Either way is fine by me.

[varshaprasad96]

/hold Will make changes after #3488 gets merged.

[joelanford]

/lgtm

Just one question

[openshift-ci-robot]

New changes are detected. LGTM label has been removed.