Skip to content

*: remove the add crd subcommand and related utilities#3547

Merged
estroz merged 1 commit intooperator-framework:masterfrom
estroz:chore/remove-add-crd
Jul 27, 2020
Merged

*: remove the add crd subcommand and related utilities#3547
estroz merged 1 commit intooperator-framework:masterfrom
estroz:chore/remove-add-crd

Conversation

@estroz
Copy link
Copy Markdown
Member

@estroz estroz commented Jul 26, 2020

Description of the change: remove the add crd subcommand and related utilities

Motivation for the change: add crd is not a part of the new CLI. Follow up from #3531.

/cc @varshaprasad96 @camilamacedo86 @asmacdo

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@varshaprasad96
Copy link
Copy Markdown
Member

Removal of add crd is also done here: #3539

@estroz
Copy link
Copy Markdown
Member Author

estroz commented Jul 26, 2020

@varshaprasad96 and in #3533. I would've liked to remove every bit of legacy code in one go but that isn't possible while ansible molecule tests are WIP (#3433), so we should remove other bits first.

Copy link
Copy Markdown
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2020
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@estroz estroz merged commit 92bb47f into operator-framework:master Jul 27, 2020
@estroz estroz deleted the chore/remove-add-crd branch July 27, 2020 05:27
@joelanford joelanford mentioned this pull request Jul 27, 2020
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants