Skip to content

doc: Fix/Update the migration guide for Go projects#3543

Merged
jmrodri merged 2 commits intooperator-framework:masterfrom
camilamacedo86:migration-go
Aug 5, 2020
Merged

doc: Fix/Update the migration guide for Go projects#3543
jmrodri merged 2 commits intooperator-framework:masterfrom
camilamacedo86:migration-go

Conversation

@camilamacedo86
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 commented Jul 25, 2020

Description of the change:
Fix/Update the migration guide with the steps required to migrate the Memcached sample

See: https://deploy-preview-3543--operator-sdk.netlify.app/docs/building-operators/golang/project_migration_guide/

Motivation for the change:
Closes: #3460
Closes: #3613
closes: #3613

@camilamacedo86 camilamacedo86 changed the title doc: migration guide go doc: Fix/Update the migration guide with the steps required to migrate the Memcached sample Jul 25, 2020
@camilamacedo86 camilamacedo86 mentioned this pull request Jul 25, 2020
92 tasks
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
@camilamacedo86 camilamacedo86 changed the title doc: Fix/Update the migration guide with the steps required to migrate the Memcached sample doc: Fix/Update the migration guide for Go projects Jul 27, 2020
@camilamacedo86 camilamacedo86 added language/go Issue is related to a Go operator project kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jul 27, 2020
Copy link
Copy Markdown
Contributor

@deepak1725 deepak1725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @camilamacedo86
LGTM

Copy link
Copy Markdown
Contributor

@bharathi-tenneti bharathi-tenneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 29, 2020
@camilamacedo86 camilamacedo86 added this to the v1.0.0 milestone Jul 30, 2020
@apm-opentt
Copy link
Copy Markdown

@camilamacedo86 I see a section for Generating Manifests and Building the operator. Can you also include how to migrate running in local mode? In v0.18.x. I use operator-sdk run local --watch-namespace=default --enable-delve to run in debug mode. What would be the v0.19.x equivalent? Would it be make run WATCHNAME=default ENABLE_DELVE?

@camilamacedo86
Copy link
Copy Markdown
Contributor Author

hi @apm-opentt,

@camilamacedo86 I see a section for Generating Manifests and Building the operator. Can you also include how to migrate running in local mode? In v0.18.x. I use operator-sdk run local --watch-namespace=default --enable-delve to run in debug mode. What would be the v0.19.x equivalent? Would it be make run WATCHNAME=default ENABLE_DELVE?

just to clarifies, this guide is for you to migrate the project to 1.0.0. IHMO: How to use delve to debug the code or run the project locally shows not in the domain of this doc. Could you please raise an issue in the repo with your question for we are able to assist you better?

Comment thread example/memcached-operator/memcached_controller.go.tmpl Outdated
Comment thread example/memcached-operator/memcached_controller.go.tmpl Outdated
Comment thread example/memcached-operator/memcached_controller.go.tmpl Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
Comment thread website/content/en/docs/building-operators/golang/project_migration_guide.md Outdated
@camilamacedo86 camilamacedo86 changed the title doc: Fix/Update the migration guide for Go projects WIP: doc: Fix/Update the migration guide for Go projects Jul 31, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 31, 2020
@camilamacedo86 camilamacedo86 changed the title WIP: doc: Fix/Update the migration guide for Go projects doc: Fix/Update the migration guide for Go projects Aug 1, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2020
@camilamacedo86
Copy link
Copy Markdown
Contributor Author

Hi @joelanford,

Feel free to check this one. All recommendations and suggestions are addressed.

Copy link
Copy Markdown
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2020
@jmrodri jmrodri merged commit 260e547 into operator-framework:master Aug 5, 2020
@camilamacedo86 camilamacedo86 deleted the migration-go branch August 5, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/documentation Categorizes issue or PR as related to documentation. language/go Issue is related to a Go operator project lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The generated controller in v0.19.0 no longer have "add" function so how do I add watches? Docs: reference to old boilerplate code

8 participants