doc: quickstart for Go projects#3551
Merged
camilamacedo86 merged 6 commits intooperator-framework:masterfrom Aug 5, 2020
camilamacedo86:doc-qquick
Merged
doc: quickstart for Go projects#3551camilamacedo86 merged 6 commits intooperator-framework:masterfrom camilamacedo86:doc-qquick
camilamacedo86 merged 6 commits intooperator-framework:masterfrom
camilamacedo86:doc-qquick
Conversation
92 tasks
Member
|
Looks great @camilamacedo86. I'm guessing the same process is in the works for the Helm section too, but the golang and ansible sections' quickstart/tutorials looks great |
joelanford
requested changes
Jul 28, 2020
Member
joelanford
left a comment
There was a problem hiding this comment.
Looks good. I have mostly the same comments that I had in the Helm Quickstart PR.
Contributor
Author
|
Hi @joelanford all suggestions and made in the Helm PR are applied here. |
Contributor
|
/lgtm |
rashmigottipati
approved these changes
Jul 29, 2020
joelanford
reviewed
Jul 30, 2020
joelanford
reviewed
Jul 30, 2020
camilamacedo86
commented
Jul 31, 2020
camilamacedo86
commented
Aug 1, 2020
camilamacedo86
commented
Aug 1, 2020
joelanford
requested changes
Aug 5, 2020
Member
joelanford
left a comment
There was a problem hiding this comment.
Review for the envtest setup doc.
joelanford
requested changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
See: https://deploy-preview-3551--operator-sdk.netlify.app/docs/building-operators/golang/quickstart/
Motivation for the change:
#3327
Closes for GO: #3590
Close: #3461