Bug 1856714: Adding checks for rescued tasks during reconciliation by VenkatRamaraju · Pull Request #3727 · operator-framework/operator-sdk

VenkatRamaraju · 2020-08-12T16:48:30Z

Description of the change:
Added a check to determine whether or not a task has been rescued.

Motivation for the change:
Avoid adding rescued tasks to the list of failures during reconciliation.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1856714
Backporting the PR #3650

openshift-ci-robot · 2020-08-12T16:48:34Z

@VenkatRamaraju: This pull request references Bugzilla bug 1856714, which is invalid:

expected Bugzilla bug 1856714 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1856714: Adding checks for rescued tasks during reconciliation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

camilamacedo86 · 2020-08-12T17:10:57Z

@@ -186,7 +186,7 @@ func (r *AnsibleOperatorReconciler) Reconcile(request reconcile.Request) (reconc
 				return reconcile.Result{}, err


It is missing the fragment with the bug fix which will be used to gen the CHANGELOG.
if it was not added in master we also need a PR with it there as well.

Oh ok. I'll make that change here & open a PR on master as well then. Thanks.

camilamacedo86 · 2020-08-12T18:26:50Z

+      Added checks for rescued tasks during reconciliation
+      to avoid adding rescued tasks to the list of failures.


Suggested change

Added checks for rescued tasks during reconciliation

to avoid adding rescued tasks to the list of failures.

Stop to reconcile tasks when the event raised is a rescue for Ansible-based Operators. More info: [Bugzilla 1856714](https://bugzilla.redhat.com/show_bug.cgi?id=1856714)

camilamacedo86 · 2020-08-12T18:27:21Z

+      Added checks for rescued tasks during reconciliation
+      to avoid adding rescued tasks to the list of failures.
+
+    kind: "addition"


Suggested change

kind: "addition"

kind: "bugfix"

Same changes to the master one.

camilamacedo86

/lgtm
/approve

after fixing the broken links. See: https://github.com/operator-framework/operator-sdk/pull/3727/checks?check_run_id=977264096#step:4:445

camilamacedo86 · 2020-08-12T22:21:09Z

 	if !goModOn {
 		return fmt.Errorf(`using go modules requires GO111MODULE="on", "auto", or unset.` +
-			` More info: https://sdk.operatorframework.io/docs/golang/quickstart/#a-note-on-dependency-management`)
+			` More info: https://sdk.operatorframework.io/docs/building-operators/golang/quickstart/`)


Suggested change

` More info: https://sdk.operatorframework.io/docs/building-operators/golang/quickstart/`)

` More info: https://v0-19-x.sdk.operatorframework.io/docs/golang/quickstart/#a-note-on-dependency-management`)

we need to point out for the doc of this branch 0.19. Also, this is the places where has the info ^

camilamacedo86 · 2020-08-12T22:23:08Z


 - Add "panic" level for --zap-stacktrace-level (allows "debug", "info", "error", "panic"). ([#3040](https://github.com/operator-framework/operator-sdk/pull/3040))
- The `operator-sdk` binary has a new CLI workflow and project layout for scaffolding Go operators that is aligned with Kubebuilder's CLI and project layout. See the new [Quickstart Guide](https://sdk.operatorframework.io/docs/golang/quickstart/) and the new [CLI reference](https://v0-19-x.sdk.operatorframework.io/docs/new-cli/) for more details. ([#3190](https://github.com/operator-framework/operator-sdk/pull/3190))
+- The `operator-sdk` binary has a new CLI workflow and project layout for scaffolding Go operators that is aligned with Kubebuilder's CLI and project layout. See the new [Quickstart Guide](https://sdk.operatorframework.io/docs/building-operators/golang/quickstart/) and the new [CLI reference](https://v0-19-x.sdk.operatorframework.io/docs/new-cli/) for more details. ([#3190](https://github.com/operator-framework/operator-sdk/pull/3190))


Same : https://v0-19-x.sdk.operatorframework.io/docs/golang/quickstart/

camilamacedo86 · 2020-08-12T22:23:18Z

 			depMsg := "Operator SDK has a new CLI and project layout that is aligned with Kubebuilder.\n" +
 				"See `operator-sdk init -h` and the following doc on how to scaffold a new project:\n" +
-				"https://sdk.operatorframework.io/docs/golang/quickstart/\n" +
+				"https://sdk.operatorframework.io/docs/building-operators/golang/quickstart/\n" +


same : https://v0-19-x.sdk.operatorframework.io/docs/golang/quickstart/

jmrodri

/lgtm

Backported #3650 and things look good.

openshift-ci-robot · 2020-08-13T18:50:20Z

@VenkatRamaraju: All pull requests linked via external trackers have merged: operator-framework/operator-sdk#3650. Bugzilla bug 1856714 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1856714: Adding checks for rescued tasks during reconciliation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Rescue reconciliation

65a0864

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 12, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 12, 2020

openshift-ci-robot requested review from fabianvf and jmrodri August 12, 2020 16:48

VenkatRamaraju changed the title ~~Bug 1856714: Adding checks for rescued tasks during reconciliation~~ Closes Bug 1856714: Adding checks for rescued tasks during reconciliation Aug 12, 2020

camilamacedo86 reviewed Aug 12, 2020

View reviewed changes

VenkatRamaraju added 2 commits August 12, 2020 10:21

Changelog fragment file

80faea6

Changes

c6f5ba8

camilamacedo86 reviewed Aug 12, 2020

View reviewed changes

Fragments

0d46207

camilamacedo86 approved these changes Aug 12, 2020

View reviewed changes

openshift-ci-robot assigned camilamacedo86 Aug 12, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2020

Added links

3fe021d

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2020

camilamacedo86 reviewed Aug 12, 2020

View reviewed changes

Formatting

f15865d

jmrodri changed the title ~~Closes Bug 1856714: Adding checks for rescued tasks during reconciliation~~ Bug 1856714: Adding checks for rescued tasks during reconciliation Aug 13, 2020

Docker changes

09fea89

VenkatRamaraju requested a review from camilamacedo86 August 13, 2020 16:20

jmrodri approved these changes Aug 13, 2020

View reviewed changes

openshift-ci-robot assigned jmrodri Aug 13, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2020

jmrodri merged commit 91c499d into operator-framework:v0.19.x Aug 13, 2020

		@@ -186,7 +186,7 @@ func (r *AnsibleOperatorReconciler) Reconcile(request reconcile.Request) (reconc
		return reconcile.Result{}, err

		Added checks for rescued tasks during reconciliation
		to avoid adding rescued tasks to the list of failures.

	Added checks for rescued tasks during reconciliation
	to avoid adding rescued tasks to the list of failures.
	Stop to reconcile tasks when the event raised is a rescue for Ansible-based Operators. More info: [Bugzilla 1856714](https://bugzilla.redhat.com/show_bug.cgi?id=1856714)

	` More info: https://sdk.operatorframework.io/docs/building-operators/golang/quickstart/`)
	` More info: https://v0-19-x.sdk.operatorframework.io/docs/golang/quickstart/#a-note-on-dependency-management`)

Conversation

VenkatRamaraju commented Aug 12, 2020

Uh oh!

openshift-ci-robot commented Aug 12, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 Aug 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camilamacedo86 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmrodri left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Aug 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

camilamacedo86 Aug 12, 2020 •

edited

Loading

camilamacedo86 left a comment •

edited

Loading