Adding checks for rescued tasks during reconciliation#3650
Merged
fabianvf merged 2 commits intooperator-framework:masterfrom Aug 11, 2020
VenkatRamaraju:rescue-reconciliation
Merged
Adding checks for rescued tasks during reconciliation#3650fabianvf merged 2 commits intooperator-framework:masterfrom VenkatRamaraju:rescue-reconciliation
fabianvf merged 2 commits intooperator-framework:masterfrom
VenkatRamaraju:rescue-reconciliation
Conversation
asmacdo
approved these changes
Aug 11, 2020
This was referenced Aug 12, 2020
jmrodri
pushed a commit
that referenced
this pull request
Aug 13, 2020
* Added fragments file * Fragment file * Changes
jmazzitelli
reviewed
Aug 26, 2020
| func (je JobEvent) Rescued() bool { | ||
| if rescued, contains := je.EventData["rescued"]; contains { | ||
| for _, v := range rescued.(map[string]interface{}) { | ||
| if int(v.(float64)) == 1 { |
There was a problem hiding this comment.
This is just a drive-by comment :) but I happened to look at this PR and wondered -- is it always the case that "rescued" will only ever be 0 or 1? Is it possible multiple tasks could be rescued and thus this count could be 2, or 3, or ???
In which case, wouldn't it be more correct to say:
if int(v.(float64)) >= 1
joelanford
pushed a commit
to joelanford/operator-sdk
that referenced
this pull request
Sep 17, 2020
…work#3650) * Stopping reconciliation on rescue * Added error check
joelanford
pushed a commit
to joelanford/operator-sdk
that referenced
this pull request
Sep 17, 2020
…onciliation) (operator-framework#3729) * Added fragments file * Fragment file * Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Added a check to determine whether or not a task has been rescued.
Motivation for the change:
Avoid adding rescued tasks to the list of failures during reconciliation.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1856714