Adding fragment file for PR #3650 (Rescue tasks reconciliation)#3729
Merged
jmrodri merged 3 commits intooperator-framework:masterfrom Aug 13, 2020
VenkatRamaraju:fragments
Merged
Adding fragment file for PR #3650 (Rescue tasks reconciliation)#3729jmrodri merged 3 commits intooperator-framework:masterfrom VenkatRamaraju:fragments
jmrodri merged 3 commits intooperator-framework:masterfrom
VenkatRamaraju:fragments
Conversation
|
|
||
| kind: "addition" | ||
|
|
||
| breaking: false |
Contributor
There was a problem hiding this comment.
The same suggestions of: https://github.com/operator-framework/operator-sdk/pull/3727/files#
|
|
||
| kind: "bugfix" | ||
|
|
||
| breaking: false No newline at end of file |
Contributor
There was a problem hiding this comment.
we need to give a space ^ nit . See the ^
|
|
||
| kind: "bugfix" | ||
|
|
||
| breaking: false No newline at end of file |
Contributor
There was a problem hiding this comment.
Since it was not added in the same PR we need to fill : pull_request_override: with the PR number.
Contributor
|
Just add the PR number in: pull_request_override: 0 and leave a space at the end of the file. |
joelanford
pushed a commit
to joelanford/operator-sdk
that referenced
this pull request
Sep 17, 2020
…onciliation) (operator-framework#3729) * Added fragments file * Fragment file * Changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Added the fragment file for #3650 (Missed in this PR).