change the operator pods' checking by jianzhangbjz · Pull Request #3884 · operator-framework/operator-sdk

jianzhangbjz · 2020-09-16T10:35:19Z

Description of the change:
Adress some issues in the merged PR 3819

Motivation for the change:

Succeeded means the Pod finished and exited. For the operator pods, they should be running all the time to monitor the CRs, so, the expected status should be Running, not Succeeded.
Sometimes, there are multi containers in a Pod. Should add the container name to distinguish them.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
Add or update relevant sections of the docs website in website/content/en/docs

jianzhangbjz · 2020-09-16T10:37:44Z

@bharathi-tenneti @jmrodri @estroz Could you help review it? Thanks!

jianzhangbjz · 2020-09-16T10:38:07Z

/assign @bharathi-tenneti

jianzhangbjz · 2020-09-16T10:41:44Z

/retest

openshift-ci-robot · 2020-09-16T10:42:00Z

@jianzhangbjz: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jmrodri · 2020-09-16T11:39:33Z

/ok-to-test

bharathi-tenneti · 2020-09-16T13:49:46Z

@jianzhangbjz Good catch, You can go ahead an remove the comments.

jianzhangbjz · 2020-09-17T03:42:46Z

Fix the below error:

- /target/docs/contribution-guidelines/testing/travis-build/index.html
  *  External link https://github.com/operator-framework/operator-sdk/blob/master/test/e2e/e2e_suite_test.go failed: 404 No error

jianzhangbjz · 2020-09-17T03:52:49Z

@bharathi-tenneti Thanks! Removed the comments.

jianzhangbjz · 2020-09-17T09:18:59Z

@jmrodri @bharathi-tenneti Could you help add the /lgtm label to merge it? Thanks!

jianzhangbjz · 2020-09-18T01:07:28Z

@jmrodri @varshaprasad96 Could you help approve it? Thanks!

jianzhangbjz · 2020-09-18T05:46:55Z

@joelanford Thanks for your suggestions! I added it. Could you help have a review again? Thanks!

jianzhangbjz · 2020-09-18T09:23:28Z

/retest

bharathi-tenneti · 2020-09-18T13:42:57Z

@jianzhangbjz just FYI, this code is being refactored. #3908
May be, you can review that PR, and see if it covers your changes.

camilamacedo86

the change shows fine.
/lgtm

jianzhangbjz · 2020-09-19T00:36:12Z

Thanks! How to address this failure?

    TASK [Fetch the kubeconfig] ****************************************************
fatal: [kind-test-local]: FAILED! => {"changed": false, "file": "/root/.kube/config", "msg": "unable to calculate the checksum of the remote file"}
    
    PLAY RECAP *********************************************************************
    kind-test-local            : ok=0    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0
    
ERROR:

jianzhangbjz · 2020-09-19T00:36:47Z

/retest

jianzhangbjz · 2020-09-29T06:49:53Z

@rafaelvanoni @bharathi-tenneti Could you help look at it? Thanks!

estroz

/lgtm

estroz · 2020-09-29T18:32:54Z

@jianzhangbjz can you rebase this with master? There was a CI change that isn't being picked up here.

camilamacedo86 · 2020-10-30T13:45:58Z

Hi @jianzhangbjz,

By checking how the master is now, shows that it is already solved. Could you please check? If yes, we can close this one. If not, could you please rebase with the master and add the new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml) for we are able to get it merged?

openshift-ci-robot · 2021-01-20T07:26:47Z

New changes are detected. LGTM label has been removed.

jianzhangbjz · 2021-01-20T07:29:20Z

Hi @camilamacedo86, I'm so sorry for the late reply. I forgot it to update it. The new logic looks good to me. But, I combine an if logic there, could you have a review? Thanks!

openshift-bot · 2021-04-20T13:05:42Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2021-05-20T16:47:01Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-bot · 2021-06-26T01:38:05Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2021-06-26T01:38:07Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from jmrodri and varshaprasad96 September 16, 2020 10:35

jianzhangbjz mentioned this pull request Sep 16, 2020

run bundle: Add deployment status check when verifying installed operator. #3819

Merged

openshift-ci-robot assigned bharathi-tenneti Sep 16, 2020

openshift-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 16, 2020

rashmigottipati approved these changes Sep 16, 2020

View reviewed changes

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2020

jianzhangbjz force-pushed the OSDK-1308 branch from 100a35b to 7d4f179 Compare September 17, 2020 03:45

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 17, 2020

joelanford reviewed Sep 18, 2020

View reviewed changes

Comment thread internal/olm/client/client.go Outdated

jianzhangbjz force-pushed the OSDK-1308 branch 2 times, most recently from 589e8cf to b73ce55 Compare September 18, 2020 08:33

camilamacedo86 reviewed Sep 18, 2020

View reviewed changes

openshift-ci-robot assigned camilamacedo86 Sep 18, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020

estroz approved these changes Sep 29, 2020

View reviewed changes

openshift-ci-robot assigned estroz Sep 29, 2020

bharathi-tenneti removed their assignment Oct 30, 2020

camilamacedo86 added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2020

save a if logic

f76852d

jianzhangbjz force-pushed the OSDK-1308 branch from b73ce55 to f76852d Compare January 20, 2021 07:26

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 20, 2021

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 20, 2021

openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 20, 2021

openshift-ci Bot closed this Jun 26, 2021

Conversation

jianzhangbjz commented Sep 16, 2020

Uh oh!

jianzhangbjz commented Sep 16, 2020

Uh oh!

jianzhangbjz commented Sep 16, 2020

Uh oh!

jianzhangbjz commented Sep 16, 2020

Uh oh!

openshift-ci-robot commented Sep 16, 2020

Uh oh!

jmrodri commented Sep 16, 2020

Uh oh!

bharathi-tenneti commented Sep 16, 2020

Uh oh!

jianzhangbjz commented Sep 17, 2020

Uh oh!

jianzhangbjz commented Sep 17, 2020

Uh oh!

jianzhangbjz commented Sep 17, 2020

Uh oh!

jianzhangbjz commented Sep 18, 2020

Uh oh!

Uh oh!

jianzhangbjz commented Sep 18, 2020

Uh oh!

jianzhangbjz commented Sep 18, 2020

Uh oh!

bharathi-tenneti commented Sep 18, 2020

Uh oh!

camilamacedo86 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jianzhangbjz commented Sep 19, 2020

Uh oh!

jianzhangbjz commented Sep 19, 2020

Uh oh!

jianzhangbjz commented Sep 29, 2020

Uh oh!

estroz left a comment

Choose a reason for hiding this comment

Uh oh!

estroz commented Sep 29, 2020

Uh oh!

camilamacedo86 commented Oct 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 20, 2021

Uh oh!

jianzhangbjz commented Jan 20, 2021

Uh oh!

openshift-bot commented Apr 20, 2021

Uh oh!

openshift-bot commented May 20, 2021

Uh oh!

openshift-bot commented Jun 26, 2021

Uh oh!

openshift-ci Bot commented Jun 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

camilamacedo86 left a comment •

edited

Loading

camilamacedo86 commented Oct 30, 2020 •

edited

Loading