runbundle: refactor printing deployment/pod errors#3908
Merged
varshaprasad96 merged 8 commits intooperator-framework:masterfrom Oct 13, 2020
Merged
runbundle: refactor printing deployment/pod errors#3908varshaprasad96 merged 8 commits intooperator-framework:masterfrom
varshaprasad96 merged 8 commits intooperator-framework:masterfrom
Conversation
2 tasks
bharathi-tenneti
force-pushed
the
refactorverifycsv
branch
from
5909f5e to
8e004b2
Compare
estroz
suggested changes
Sep 28, 2020
jmrodri
dismissed
their stale review
In light of eric's comments, I'm rescinding my lgtm
Member
|
@bharathi-tenneti I honestly prefer the original implementation of this PR: d987f78 I think we should go back to that. I see @estroz point in that Result is meant for the validation and not meant to be a general error framework. @camilamacedo86 point is valid which is why we could make |
estroz
suggested changes
Oct 2, 2020
| return err | ||
| if s.Type == appsv1.DeploymentAvailable && s.Status != corev1.ConditionTrue { | ||
| podError := c.checkPodErrors(ctx, depSelectors, key) | ||
| if podError.Error() == "" { |
Member
There was a problem hiding this comment.
Suggested change
| if podError.Error() == "" { | |
| if podError == nil { |
| name: ds.Name, | ||
| issue: s.Reason, | ||
| }) | ||
| return depErr |
Member
There was a problem hiding this comment.
Other deployments may have errors
Suggested change
| return depErr | |
| break |
| name: ds.Name, | ||
| issue: podError.Error(), | ||
| }) | ||
| return depErr |
Member
There was a problem hiding this comment.
Other deployments may have errors
Suggested change
| return depErr | |
| break |
estroz
suggested changes
Oct 2, 2020
Contributor
|
Hii @estroz, WDYT about merge this one and we working on in the fix/improvements in a follow-up. Do you see something that is a blocker to get it merged? |
Member
|
@camilamacedo86 : Have taken this up from Bharathi. I can make the suggested changes and push it to this PR. |
Member
|
Have addressed review comments |
estroz
pushed a commit
to estroz/operator-sdk
that referenced
this pull request
Oct 14, 2020
…k#3908) * refactor printDeployment and printPodError funcs * Addressing PR comments * fix sanity error * Reverting a2ed4 and 8e004 * Reverting a2ed4 and 8e004 * Addressing PR comments * Added podError struct, and other PR comments * Address review comments Co-authored-by: varshaprasad96 <varshaprasad96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Refactor the existing
printDeploymentErrorsandprintPodErrors()functions fromclient.goto collect and return errors in a struct/map.https://github.com/operator-framework/operator-sdk/blob/master/internal/olm/client/client.go
Have the return type defined as custom error, for re-usability.
Refactor the test cases and write new ones as needed based on above code re-factor.