OWNERS: add OWNERS_ALIASES, add approvers/reviewers who already held roles#3955
Merged
estroz merged 1 commit intooperator-framework:masterfrom Sep 28, 2020
Merged
Conversation
openshift-ci-robot
added
the
do-not-merge/invalid-owners-file
Member
Author
|
I've also moved @hasbro17 and @shawn-hurley to the |
openshift-ci-robot
removed
the
do-not-merge/invalid-owners-file
hasbro17
approved these changes
Sep 28, 2020
Contributor
hasbro17
left a comment
hasbro17
left a comment
There was a problem hiding this comment.
This won't stop me from reviewing 😛
LGTM
…d those who already hold these roles
estroz
force-pushed
the
chore/owners-aliases-grandfathering
branch
from
e901e21 to
6039a21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change: add an OWNERS_ALIASES file with appropriate labels for admins, approvers, and reviewers.
Motivation for the change: now that operator-framework/community#12 has been merged, the OWNERS and OWNERS_ALIASES files should exist and hold the current set of approvers and reviewers at all times, each of which will have to follow community guidelines from the linked document.
Added @asmacdo to
sdk-approverssince he meets the criteria and has been acting as an approver for a long time.Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs