community-membership.md: add community membership guidelines#12
Conversation
estroz
requested review from
dmesser,
dmueller2001,
ecordell,
joelanford and
robszumski
|
/lgtm |
|
|
||
| New contributors should be welcomed to the community by existing members, | ||
| helped with PR workflow, and directed to relevant documentation and | ||
| communication channels. |
There was a problem hiding this comment.
do we have a "getting started for contributors" doc? If so, we should link it here (if not, lemme add a TODO).
There was a problem hiding this comment.
Here's what we currently have. This doc should be mentioned somewhere in these docs
https://github.com/operator-framework/operator-sdk/blob/master/CONTRIBUTING.MD
https://sdk.operatorframework.io/docs/contribution-guidelines/
|
I've been busy with the SDK v1.0 release, will get around to these comments soon. |
|
I think we need a section for community co-chairs. There might(?) have been a plan to add that in a separate PR but I can't find any reference to that, it might have gotten lost in the shuffle. |
|
@jberkhahn you mean community co-chair election? There should be a (s)election process for appointment, so that should be tackled in a separate document. I don't have any plans to work on one personally. |
|
Yeah, I mean a section that says what a community co-chair is, what they do. I thought we had discussed that in the past but can't find that anywhere. |
| The following apply to the part of codebase for which one would be a reviewer in | ||
| an [OWNERS] file (for repos using the bot). | ||
|
|
||
| - Code reviewer status may be a precondition to accepting large code contributions |
There was a problem hiding this comment.
"may be" is a little unclear. I assume that this precondition would be made by existing reviewers/approvers as part of a PR review?
There was a problem hiding this comment.
This would read better as: "Large code contributions by non-reviewers is acceptable at the discretion of existing PR reviewers"
|
|
||
| New contributors should be welcomed to the community by existing members, | ||
| helped with PR workflow, and directed to relevant documentation and | ||
| communication channels. |
There was a problem hiding this comment.
Here's what we currently have. This doc should be mentioned somewhere in these docs
https://github.com/operator-framework/operator-sdk/blob/master/CONTRIBUTING.MD
https://sdk.operatorframework.io/docs/contribution-guidelines/
estroz
force-pushed
the
chore/community-membership
branch
from
e4965b5 to
87fb010
Compare
|
New changes are detected. LGTM label has been removed. |
estroz
force-pushed
the
chore/community-membership
branch
from
87fb010 to
fcc87b0
Compare
12 participants
Add community membership guidelines and membership issue template.