e2e tests: migrate the memcached molecule tests to use the new layout (1.0+) with mock samples stack#4011
Merged
camilamacedo86 merged 1 commit intooperator-framework:masterfrom Oct 23, 2020
camilamacedo86:molecule-ansible
Merged
e2e tests: migrate the memcached molecule tests to use the new layout (1.0+) with mock samples stack#4011camilamacedo86 merged 1 commit intooperator-framework:masterfrom camilamacedo86:molecule-ansible
camilamacedo86 merged 1 commit intooperator-framework:masterfrom
camilamacedo86:molecule-ansible
Conversation
camilamacedo86
commented
Oct 11, 2020
|
|
||
| samples: ## Generate samples | ||
| go run ./hack/generate/samples/generate_all.go | ||
| go run ./hack/generate/samples/generate_testdata.go |
Contributor
Author
There was a problem hiding this comment.
make more sense be generate_testdata
it also makes more simplicity its goal.
camilamacedo86
commented
Oct 11, 2020
| @@ -27,13 +27,14 @@ import ( | |||
| "github.com/operator-framework/operator-sdk/internal/testutils" | |||
| ) | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
just moving the vars to the main for not let them global in the pkg.
camilamacedo86
commented
Oct 11, 2020
| memcached.Prepare() | ||
| memcached.Run() | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
The consts were centralized in the constants.go file.
camilamacedo86
commented
Oct 11, 2020
camilamacedo86
changed the title
camilamacedo86
added
language/ansible
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
|
@camilamacedo86 yeah, the memcached tests look like they were properly captured, but the tests in |
camilamacedo86
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
commented
Oct 14, 2020
| cd $TMPDIR | ||
| KUSTOMIZE_PATH=${KUSTOMIZE} | ||
| header_text "Test Ansible Molecule scenarios" | ||
| pushd "${ROOTDIR}/test/ansible" |
Contributor
Author
There was a problem hiding this comment.
See that a pr to change it will be done as a follow up: https://github.com/operator-framework/operator-sdk/pull/4011/files
openshift-ci-robot
added
needs-rebase
camilamacedo86
changed the title
|
New changes are detected. LGTM label has been removed. |
This was referenced Oct 21, 2020
asmacdo
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Motivation for the change:
PS: We can check the Memcached mock project used to run the molecule tests by exec
go run ./hack/generate/samples/molecule/generate.goThen, we can see the project in the testdata/ansible/memcached-molecule-operator with all molecule tests and checks.NOTE as a follow up we need to do the test/ansible also be in the new layout and mocked via sample stack. See: #4025
Closes: #3540