e2e-tests: fix advanced molecule ansible tests#4273
Merged
camilamacedo86 merged 1 commit intooperator-framework:masterfrom Dec 15, 2020
camilamacedo86:fix-molecule
Merged
e2e-tests: fix advanced molecule ansible tests#4273camilamacedo86 merged 1 commit intooperator-framework:masterfrom camilamacedo86:fix-molecule
camilamacedo86 merged 1 commit intooperator-framework:masterfrom
camilamacedo86:fix-molecule
Conversation
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
requested review from
asmacdo,
estroz and
fabianvf
and removed request for
fabianvf
camilamacedo86
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
estroz
reviewed
Dec 14, 2020
Member
estroz
left a comment
estroz
left a comment
There was a problem hiding this comment.
If this test is generating a v1 sample shouldn’t it exist under testdata/ansible/memcached-molecule-operator?
asmacdo
reviewed
Dec 15, 2020
| env | ||
| export PATH=/opt/python/3.6.7/bin:${PATH} | ||
| sudo apt-get install python3 python3-pip | ||
| sudo pip3 install wheel |
Contributor
Author
There was a problem hiding this comment.
Because we only added this in the PR https://github.com/operator-framework/operator-sdk/pull/4253/files#diff-b40bad6fd0ff24f0b76e97122134b4fb2df604d6b73e4ddbd88bf5229f6c9912R34. It was not used/set before that and it's not required.
reinvantveer
pushed a commit
to reinvantveer/operator-sdk
that referenced
this pull request
Feb 5, 2021
**Description of the change:** - update advanced mock static scenario with 1.0+ layout (operator-framework#3433) - (note that we need to ensure that the test works with the new layout) - Fix CI issue (blocker master): `The error was: urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='172.30.99.1', port=24443): Max retries exceeded with url: /version (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f28647cdb38>: Failed to establish a new connection: [Errno 110] Connection timed out',))` in GA. NOTE: The follow up here is to replace the test/ansible static mock with samples to ensure that we are testing it with the latest changes always. See the issue operator-framework#4025 and its PR : operator-framework#4312 Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
The error was: urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='172.30.99.1', port=24443): Max retries exceeded with url: /version (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f28647cdb38>: Failed to establish a new connection: [Errno 110] Connection timed out',))in GA.NOTE: The follow up here is to replace the test/ansible static mock with samples to ensure that we are testing it with the latest changes always. See the issue #4025 and its PR : #4312