fix: (helm) - prevent sync from deleting all release records if Helm failed to transition state properly during upgrade

[mikeshng]

Signed-off-by: Mike Ng ming@redhat.com

Description of the change:
If the 2nd last release record is superseded which indicates that a upgrade has been successfully performed, but the last release is still pending-upgrade which indicates that there Helm did not transition the status properly, then transition the last release record to deployed status.

Motivation for the change:
Due to Helm upgrade release status transition not being an atomic update, see helm/helm#9113
it's possible that the Helm release records are left in the following state after an upgrade:
original release's status is superseded
upgraded release's status is stuck at pending-upgrade
If this is the case, then Helm operator will proceed to remove both of these release records in the Manager's Sync function.
This change is to fix the Helm storage to move the last release into deployed status to prevent all the release records from being deleted.

Checklist

If the pull request includes user-facing changes, extra documentation is required:

• [NA] Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
  bug fix
• [NA] Add or update relevant sections of the docs website in website/content/en/docs

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci]

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.