Skip to content

fix: (helm) - prevent sync from deleting all release records if Helm failed to transition state properly during upgrade #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikeshng wants to merge 1 commit into from
Closed

fix: (helm) - prevent sync from deleting all release records if Helm failed to transition state properly during upgrade #4358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions internal/helm/release/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import (
"helm.sh/helm/v3/pkg/kube"
helmkube "helm.sh/helm/v3/pkg/kube"
rpb "helm.sh/helm/v3/pkg/release"
"helm.sh/helm/v3/pkg/releaseutil"
"helm.sh/helm/v3/pkg/storage"
"helm.sh/helm/v3/pkg/storage/driver"
apiextv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
Expand Down Expand Up @@ -98,6 +99,23 @@ func (m *manager) Sync(ctx context.Context) error {
return fmt.Errorf("failed to retrieve release history: %w", err)
}

// If the 2nd last release is in status 'superseded' and the last release is in status 'pending-upgrade'
// then transition the last release to status 'deployed'. See https://github.com/helm/helm/issues/9113
if len(releases) >= 2 {
releaseutil.SortByRevision(releases)
secondLastRelease := releases[len(releases)-2]
lastRelease := releases[len(releases)-1]

if secondLastRelease.Info != nil && secondLastRelease.Info.Status == rpb.StatusSuperseded &&
lastRelease.Info != nil && lastRelease.Info.Status == rpb.StatusPendingUpgrade {
lastRelease.Info.Description = "Upgrade complete"
lastRelease.Info.Status = rpb.StatusDeployed
if err := m.storageBackend.Update(lastRelease); err != nil {
return fmt.Errorf("failed to transition last release to deployed status: %w", err)
}
}
}

// Cleanup non-deployed release versions. If all release versions are
// non-deployed, this will ensure that failed installations are correctly
// retried.
Expand Down