Skip to content

Pin docker base images#4417

Merged
estroz merged 7 commits intooperator-framework:masterfrom
reinvantveer:pin_docker_base_images
Feb 1, 2021
Merged

Pin docker base images#4417
estroz merged 7 commits intooperator-framework:masterfrom
reinvantveer:pin_docker_base_images

Conversation

@reinvantveer
Copy link
Copy Markdown
Contributor

Description of the change:
Pin Docker base images for Ansible operator and Helm operator

Motivation for the change:
Pinning Docker images reduces the chance of facing a dependency conflict resulting from differences in base images. "Latest" base image bugs are very hard to discover - the user may have pulled a newer image without knowing.

This merge request is in response to in accordance with #4413 (comment) and is part of addressing the discussion in issue #4237

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
@reinvantveer
Copy link
Copy Markdown
Contributor Author

@estroz @dalbani

Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
Copy link
Copy Markdown
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reinvantveer mind pinning all the other ubi images in images/ while you're at it?

…s well

Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
…iption

Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
@reinvantveer
Copy link
Copy Markdown
Contributor Author

Consider it pinned :P

Copy link
Copy Markdown
Member

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@estroz
Copy link
Copy Markdown
Member

estroz commented Jan 21, 2021

/cc @asmacdo

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2021
Copy link
Copy Markdown
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@estroz estroz merged commit 70b89ed into operator-framework:master Feb 1, 2021
@reinvantveer reinvantveer deleted the pin_docker_base_images branch February 3, 2021 12:31
@reinvantveer
Copy link
Copy Markdown
Contributor Author

Good to see progress on this!

reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 4, 2021
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 4, 2021
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
reinvantveer pushed a commit to reinvantveer/operator-sdk that referenced this pull request Feb 5, 2021
Signed-off-by: Rein van 't Veer <reinvantveer@gmail.com>
Signed-off-by: reinvantveer <rein.van.t.veer@geodan.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants