Skip to content

Pin docker base images #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
estroz merged 7 commits into from
Feb 1, 2021
Merged

Pin docker base images #4417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
05aaa26
pin Dockerfile base images to create reproducible builds
reinvantveer Jan 21, 2021
223b80f
explain what/why of the change
reinvantveer Jan 21, 2021
976a109
fix copy/paste error for current ubi-minimal base image version
reinvantveer Jan 21, 2021
0f44233
pin base image versions for custom-scorecard-tests and operator-sdk a…
reinvantveer Jan 21, 2021
2ba68eb
update to reflect pinning all images, rename change file to fit descr…
reinvantveer Jan 21, 2021
5b1b4d1
pin Docker base image for scorecard test
reinvantveer Jan 21, 2021
f69975e
update to reflect pinning scorecard test base image
reinvantveer Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions changelog/fragments/pin-docker-base-images.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# entries is a list of entries to include in
# release notes and/or the migration guide
entries:
- description: >
For Ansible-based and Helm-based operators, as well as for the
Operator SDK and the (custom) scorecard tests, the Docker base images
are pinned to improve the reproducibility of builds using Docker.

kind: addition

# Is this a breaking change?
breaking: false
2 changes: 1 addition & 1 deletion images/ansible-operator/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.access.redhat.com/ubi8/ubi:latest
FROM registry.access.redhat.com/ubi8/ubi:8.3-227

RUN mkdir -p /etc/ansible \
&& echo "localhost ansible_connection=local" > /etc/ansible/hosts \
Expand Down
3 changes: 1 addition & 2 deletions images/custom-scorecard-tests/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# Base image
FROM registry.access.redhat.com/ubi8/ubi-minimal:latest
FROM registry.access.redhat.com/ubi8/ubi-minimal:8.3-230

ENV HOME=/opt/custom-scorecard-tests \
USER_NAME=custom-scorecard-tests \
Expand Down
2 changes: 1 addition & 1 deletion images/helm-operator/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.access.redhat.com/ubi8/ubi-minimal:latest
FROM registry.access.redhat.com/ubi8/ubi-minimal:8.3-230

ENV HOME=/opt/helm \
USER_NAME=helm \
Expand Down
2 changes: 1 addition & 1 deletion images/operator-sdk/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.access.redhat.com/ubi8/ubi-minimal:latest
FROM registry.access.redhat.com/ubi8/ubi-minimal:8.3-230

RUN microdnf install -y golang make which

Expand Down
2 changes: 1 addition & 1 deletion images/scorecard-test/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM registry.access.redhat.com/ubi8/ubi-minimal:latest
FROM registry.access.redhat.com/ubi8/ubi-minimal:8.3-230

ENV HOME=/opt/scorecard-test \
USER_NAME=scorecard-test \
Expand Down