pkg/ansible: Adding paramconv and kubeconfig to ansible operator.#471
Merged
shawn-hurley merged 1 commit intoSep 17, 2018
Merged
Conversation
shawn-hurley
force-pushed
the
feature/add-AO-proxy-param
branch
from
9f01c6f to
6e73bbd
Compare
hasbro17
reviewed
Sep 12, 2018
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // Based on https://github.com/iancoleman/strcase |
Contributor
There was a problem hiding this comment.
Probably don't need the last line. We already have this license in the SDK
https://github.com/operator-framework/operator-sdk/blob/master/commands/operator-sdk/main.go#L1-L13
Contributor
|
LGTM after nit. |
shawn-hurley
force-pushed
the
feature/add-AO-proxy-param
branch
from
6e73bbd to
ca3d1a3
Compare
fanminshi
reviewed
Sep 14, 2018
| "strings" | ||
| ) | ||
|
|
||
| var numberSequence = regexp.MustCompile(`([a-zA-Z])(\d+)([a-zA-Z]?)`) |
Contributor
There was a problem hiding this comment.
our codebase uses var block consistently. maybe we should do it here too?
e. g
var (
numberSequence = ...
numberReplacement= ...
wordMapping = ...
)
shawn-hurley
force-pushed
the
feature/add-AO-proxy-param
branch
from
ca3d1a3 to
de44e56
Compare
fanminshi
reviewed
Sep 17, 2018
| if req.Method == http.MethodPost { | ||
| logrus.Info("injecting owner reference") | ||
| dump, _ := httputil.DumpRequest(req, false) | ||
| fmt.Println(string(dump)) |
Contributor
There was a problem hiding this comment.
why printing the dump file here?
| owner := metav1.OwnerReference{} | ||
| json.Unmarshal(authString, &owner) | ||
|
|
||
| logrus.Printf("%#+v", owner) |
Contributor
There was a problem hiding this comment.
is this a debugging statement or actual log? If using actual log, we probably should use logrus.Infof().
| http.Error(w, m, http.StatusInternalServerError) | ||
| return | ||
| } | ||
| logrus.Printf(string(newBody)) |
Contributor
There was a problem hiding this comment.
same here. is this a debugging statement or normal logging. If normal logging, we should use logrus.Infof().
shawn-hurley
force-pushed
the
feature/add-AO-proxy-param
branch
from
de44e56 to
0205fb6
Compare
Contributor
|
lgtm |
hasbro17
pushed a commit
to hasbro17/operator-sdk
that referenced
this pull request
Oct 3, 2018
shawn-hurley
pushed a commit
to shawn-hurley/operator-sdk
that referenced
this pull request
Oct 12, 2018
operator-framework#566) * pkg/ansible: Adding paramconv and kubeconfig to ansible operator. (operator-framework#471) * Adding runner package. (operator-framework#472) * pkg/ansible: Adding ansible operator controller and events package (operator-framework#473) * make ansible task log outputs more readable (operator-framework#545)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.